Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: ExitOnResponse default is actually false #128

Closed
jamieburchell opened this issue Feb 5, 2019 · 2 comments
Closed

Docs: ExitOnResponse default is actually false #128

jamieburchell opened this issue Feb 5, 2019 · 2 comments

Comments

@jamieburchell
Copy link
Contributor

The confirm(), error() and reject() methods will all exit the application immediately to prevent additional output being added to the response. You can disable this by setting the exitOnResponse option

It seems that the default is now false
@judgej
Copy link
Member

judgej commented Mar 28, 2019

Do we just need to change the documentation? It makes more sense this way to me - no library should be exiting on behalf of whatever framework it is in.

judgej added a commit that referenced this issue Jun 18, 2019
@judgej
Issue #128 update to default exitOnResponse action documentation
6bb89ea
@judgej
Copy link
Member

judgej commented Jun 18, 2019

Updated docs.

@judgej judgej closed this as completed Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@judgej @jamieburchell