sort require & opt. example #1462
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sephster
requested changes
Dec 4, 2024
| * PHP 8.2 | ||
| * PHP 8.3 | ||
| * PHP 8.4 | ||
| https://github.com/thephpleague/oauth2-server/blob/7b9ec37d5077c0382aa3748c6e125c5408d5adb9/composer.json#L7 |
There was a problem hiding this comment.
I think the previous format is preferable as the readme should be easily accessible. I think this change reduces that
| @@ -4,28 +4,27 @@ | |||
| "homepage": "https://oauth2.thephpleague.com/", | |||
| "license": "MIT", | |||
| "require": { | |||
| "php": "~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0", | |||
| "php": "^8.1 || ^8.2 || ^8.3 || ^8.4", | |||
There was a problem hiding this comment.
please can we revert this change? I can't remember the reasons why but we did have the constraint as ^8.0 at one point but it was reverted to ~. I think we will change to just ^9.0 when a new major PHP ver is released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fyi/
localhostresults in IPv6 @ newer MacOS versions