Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: config response type class #119

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

develth
Copy link
Contributor

@develth develth commented Jan 26, 2023

fixes #118

@icanhazstring
Copy link

icanhazstring commented Mar 1, 2024

Can we get this merged? @chalasr
I am directly looking for that, to get https://github.com/steverhoades/oauth2-openid-connect-server working.

Otherwise there is not suitable way to inject a custom ResponseTypeInterface into the AuthorizationServer.

@chalasr
Copy link
Member

chalasr commented Mar 10, 2024

I'm waiting for the (draft) to be removed from the PR title :)

@chalasr
Copy link
Member

chalasr commented Mar 10, 2024

Dunno why the GHA builds didn't run though

@develth develth changed the title feat: config response type class (draft) feat: config response type class Mar 10, 2024
@develth
Copy link
Contributor Author

develth commented Mar 10, 2024

I'm waiting for the (draft) to be removed from the PR title :)

Removed it :)
Should I apply the fix by @mrardon or do you add it?
And why the laugh @mrardon ?

@chalasr
Copy link
Member

chalasr commented Mar 10, 2024

Thanks!
Given this is open for more than a year, I’ll happily take care of making the change if you don’t (+ rebase to trigger the CI)

@develth
Copy link
Contributor Author

develth commented Mar 10, 2024

Go for it, i can't do it until tomorrow ✌️👍

@develth develth closed this Mar 10, 2024
@develth develth reopened this Mar 10, 2024
@chalasr chalasr force-pushed the feat/config-response-type branch from 4a294c4 to 44f1dc3 Compare March 10, 2024 19:55
@chalasr chalasr force-pushed the feat/config-response-type branch from 4ea6bef to 6afd832 Compare March 10, 2024 20:40
@chalasr
Copy link
Member

chalasr commented Mar 10, 2024

Thank you @develth.

@chalasr chalasr merged commit bd18468 into thephpleague:master Mar 10, 2024
0 of 10 checks passed
@mrardon
Copy link

mrardon commented Mar 11, 2024

And why the laugh @mrardon ?

@develth Whoops I'm blind lol meant +1 👍. Thanks for this!

@develth
Copy link
Contributor Author

develth commented Mar 11, 2024

And why the laugh @mrardon ?

@develth Whoops I'm blind lol meant +1 👍. Thanks for this!

Thx, thought i did a bullshit commit message :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom BearerTokenResponse / AuthorizationServer
4 participants