add oTel grpc instrumentation #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
py4chen
commented
Nov 7, 2024
| ) | ||
|
|
||
| otel.SetMeterProvider(meterProvider) | ||
|
|
There was a problem hiding this comment.
Trace provider can be added here in the future.
py4chen
force-pushed
the
pchen06/add-otel
branch
from
51c5b07 to
1343e9b
Compare
py4chen
requested review from
maditya,
hkadakia and
adavis10006
and removed request for
adavis10006,
maditya and
hkadakia
maditya
reviewed
Nov 11, 2024
py4chen
force-pushed
the
pchen06/add-otel
branch
from
ac68d2f to
33073d7
Compare
maditya
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR introduces
otelgrpc.NewServerHandlerto grpc server.Follow-ups: add metrics for grpc-http gateway, and panics.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.