Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make slow queries more pleasant within the UI #914

Closed
John-Gee opened this issue Jan 19, 2024 · 9 comments
Closed

Make slow queries more pleasant within the UI #914

John-Gee opened this issue Jan 19, 2024 · 9 comments

Comments

@John-Gee
Copy link

Hello,

When I manually run queries against my various indexers some of them take a long time to reply. I am not sure how you currently do it, so I apologize if I say anything dumb/redundant.

1- Since we have stats, it'd be probably nicer, on average, to make sure to start querying the slower indexers first, though if you fire all queries within a few ms already that would not make much of a difference.

2- It'd be also nice to have a soft timeout limit, in the sense that after that timeout queries will continue to run but in the background so we don't have to wait to start interacting. Of course that would be useless if no result have been found yet and I'm not certain how to properly update the UI without disturbing the user. Likely this would be an opt-in feature.

Thank you!

@theotherp
Copy link
Owner

  1. It's indeed a matter of 1 or 2 ms as they're queried in multiple threads in parallel. The order is irrelevant in this case.

  2. Adding additional results on the go while more indexers respond would result in unpredictable changes to the table. I could (and already considered a long time ago) replacing the "Cancel" button with a kinda of "That's enough" functionality where you're shown the results from the indexers which have already responded. There's really no reason to have Cancel abort everything. But as I've said in other posts I really don't have much free time right now. I'll keep it in mind.

@John-Gee
Copy link
Author

Yeah the cancel does indeed not make much sense I agree.

@theotherp
Copy link
Owner

How do you run hydra? I could send you a beta version but only if you're not running docker.

@John-Gee
Copy link
Author

I run the compiled version on straight Linux x64.

I've thought a bit more about "Adding additional results on the go", it could be part of the "Load More" button, or a separate one if that makes more sense.

Thank you!

@theotherp
Copy link
Owner

Try this then: https://ufile.io/12grcpa9

Just replace the file in the main folder.

@John-Gee
Copy link
Author

With that version the cancel button does not seem to do anything. I keep clicking it but nothing happens.

@theotherp
Copy link
Owner

You'r right. WTF, it worked yesterday...

@theotherp
Copy link
Owner

Got it, the UI source changes got reverted by mistake. This one should work: https://ufile.io/cnlygr8x

@John-Gee
Copy link
Author

Yup that works! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants