Security improvements: use valid HTTPS where possible #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, the requests library verifies TLS certs so this improves security. As it was, any outgoing requests through these methods could have been man-in-the-middled.
|
Thanks. I will take over your changes and add a configuration to switch the behavior. For this I will add the changes manually and reject this PR, so you know. |
theotherp
pushed a commit
that referenced
this pull request
Jul 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These minor changes use valid HTTPS for outgoing connections to different services or web requests in general. The different APIs are available over HTTPS now (including ipinfo which allows its IP lookup @ https://ipinfo.io/ip for free).
As for the general
webaccess.getandwebaccess.post, verifying TLS/SSL ensures that the connection is secured, avoiding man in the middle attacks or otherwise connecting to a service with any form of invalid cert. This makes for better standard security overall.I see that #138 exists but if a device's SSL is broken or old that it can't connect to a valid https:// address, then there's a lot wrong with the device/system. If broken SSL implementations had to be supported, then another option could be to add a "Don't verify SSL" option to the settings (eg how SABnzbd does it). In that case, the default should be to always verify and maybe add a warning message in the UI against disabling the setting.