feat: Do not automatically assign demoUsers the teamEditor role within the Templates team
#3878
Conversation
DafyddLlyr
changed the title
demoUsers the teamEditor role within the Templates team
DafyddLlyr
force-pushed
the
dp/demo-user-trigger-update
branch
from
fc95e79 to
7994d30
Compare
|
|
||
| CREATE CONSTRAINT TRIGGER grant_new_user_template_team_access | ||
| AFTER INSERT ON users | ||
| DEFERRABLE INITIALLY DEFERRED |
There was a problem hiding this comment.
DEFERRABLE INITIALLY DEFERRED is new to me!
This ensures that the the trigger will run post commit, not post insert.
The insert of a new user and the associated demoUser role are grouped into a single transaction via the GraphQL mutation here.
Without DEFERRABLE INITIALLY DEFERRED, the trigger will run after the user has been inserted and then hit a race condition against insertion of the team_member record (it may check for the record before it's been inserted).
This will now wait until both the users record and team_members record has been inserted before running.
| const response = await safely(() => | ||
| $admin.client.request<{ insertUsersOne: { id: number } }>( | ||
| gql` | ||
| mutation CreateAndAddUserToTeam( |
There was a problem hiding this comment.
This matches the query on the frontend - might be a good reason to wrap up on planx-core?
DafyddLlyr
force-pushed
the
dp/demo-user-trigger-update
branch
from
7994d30 to
b63b6e3
Compare
|
Removed vultr server and associated DNS entries |
What does this PR do?
demoUserrole, they are not automatically granted theteamEditorrole in the "templates" team✅ Regression tests passing against this branch here