chore: Upgrade immer to v9 #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
commented
Aug 30, 2022
Comment on lines
18
to
+20
| expect(ops).toEqual([ | ||
| { od: ["a", "b"], oi: ["b", "a"], p: ["_root", "edges"] }, | ||
| { p: ["_root", "edges", 0], ld: "a", li: "b" }, | ||
| { p: ["_root", "edges", 1], ld: "b", li: "a" }, |
There was a problem hiding this comment.
A little tricky to get to the bottom of this one initially. The test fails once v8.0.2 is installed, changelog here - https://github.com/immerjs/immer/releases/tag/v8.0.2
I believe this is the relevant change - immerjs/immer#648
Essentially, the move() graph function now generates two "list" (li & ld) operations as opposed to a two "object" operations (od & oi).
|
Removed vultr server and associated DNS entries |
gunar
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had a few issues with types and tests when I tried to tackle this in previous PR - #1047
All seems good now though 👌