Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade testing dependencies #203

Closed
wants to merge 8 commits into from

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Oct 10, 2022

Tests succeed here in their usual ~30sec, but CI fails to recognize the step is done and keeps running until eventually timing out:
Screenshot from 2022-10-10 14-48-53

I've tried a bunch of different suggestions from these threads with no luck:

Suggestions welcome!!

@netlify
Copy link

netlify bot commented Oct 10, 2022

Deploy Preview for oslmap ready!

Name Link
🔨 Latest commit a9df066
🔍 Latest deploy log https://app.netlify.com/sites/oslmap/deploys/63441f082100310008e2f8c1
😎 Deploy Preview https://deploy-preview-203--oslmap.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@DafyddLlyr
Copy link
Contributor

DafyddLlyr commented Oct 13, 2022

@jessicamcinchak Did a bit of deep dive on this last night without much success. I can recreate exactly what you're describing above - all tests pass but the test runner doesn't quit.

Jest has a --detectOpenHandles flag but I can't see anything similar in the vitest docs that would allow us to identify any processes which are still running.

One thing of note - the regression appears to have been introduced in vitest v0.22.0 - any higher version seems to have this issue, but the previous version works fine (v0.21.1). One pragmatic solution (for now) could be to upgrade to this version.

I also tried narrowing down suites of tests to see if there was a particular one which was causing this. The issue pretty much seems to be with all tests (so maybe something related to happyDom().whenAsyncComplete()...?). A simple expect(true).toBe(true) passes and the test runner quits all the way up to vite v0.24.1 (current).

Going to keep looking at it but wanted to share findings so far - looking through happyDom docs and releases now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants