Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduled monthly dependency update for October #219

Merged
merged 5 commits into from
Oct 3, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions mysensors/cli/gateway_mqtt.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,8 @@ class MQTTClient:
def __init__(self, broker, port=1883, keepalive=60):
"""Set up MQTT client."""
try:
import paho.mqtt.client as mqtt # pylint: disable=import-error
# pylint: disable=import-error, import-outside-toplevel
import paho.mqtt.client as mqtt
except ImportError:
_LOGGER.error(
'paho.mqtt.client is missing. '
Expand Down Expand Up @@ -224,7 +225,8 @@ def unregister_write(self, client, userdata, sock):

async def run_misc_loop(self):
"""Provide loop for paho mqtt."""
import paho.mqtt.client as mqtt # pylint: disable=import-error
# pylint: disable=import-error, import-outside-toplevel
import paho.mqtt.client as mqtt
while self._client.loop_misc() == mqtt.MQTT_ERR_SUCCESS:
try:
await asyncio.sleep(1)
Expand Down
2 changes: 1 addition & 1 deletion mysensors/validation.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def is_version(value):
"""Validate that value is a valid version string."""
try:
value = str(value)
if not parse_ver('1.4') <= parse_ver(value):
if parse_ver('1.4') > parse_ver(value):
raise ValueError()
return value
except (AttributeError, TypeError, ValueError):
Expand Down
2 changes: 1 addition & 1 deletion requirements_pypi.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
pygcgen==0.2.4
setuptools==41.2.0
twine==1.13.0
twine==2.0.0
wheel==0.33.6
4 changes: 2 additions & 2 deletions requirements_test.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
flake8==3.7.8
pylint==2.3.1
pytest==5.1.2
pylint==2.4.2
pytest==5.2.0
pytest-cov==2.7.1
pytest-sugar==0.9.2
pytest-timeout==1.3.3
Expand Down
2 changes: 2 additions & 0 deletions tests/test_message.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
from mysensors.const_14 import Internal, MessageType
from mysensors.task import SyncTasks

# pylint: disable=unnecessary-comprehension

PRES_FIXTURES_14 = {
'S_DOOR': 'Front Door',
'S_ARDUINO_NODE': '1.4',
Expand Down