Scheduled monthly dependency update for October (#219)

* Update twine from 1.13.0 to 2.0.0

* Update pylint from 2.3.1 to 2.4.2

* Update pytest from 5.1.2 to 5.2.0

* Fix lint except unnecessary-comprehension

* Temporary disable unnecessary-comprehension

mysensors/cli/gateway_mqtt.py

@@ -96,7 +96,8 @@ class MQTTClient:
     def __init__(self, broker, port=1883, keepalive=60):
         """Set up MQTT client."""
         try:
-            import paho.mqtt.client as mqtt  # pylint: disable=import-error
+            # pylint: disable=import-error, import-outside-toplevel
+            import paho.mqtt.client as mqtt
         except ImportError:
             _LOGGER.error(
                 'paho.mqtt.client is missing. '
@@ -224,7 +225,8 @@ def unregister_write(self, client, userdata, sock):
 
     async def run_misc_loop(self):
         """Provide loop for paho mqtt."""
-        import paho.mqtt.client as mqtt  # pylint: disable=import-error
+        # pylint: disable=import-error, import-outside-toplevel
+        import paho.mqtt.client as mqtt
         while self._client.loop_misc() == mqtt.MQTT_ERR_SUCCESS:
             try:
                 await asyncio.sleep(1)

mysensors/validation.py

@@ -16,7 +16,7 @@ def is_version(value):
     """Validate that value is a valid version string."""
     try:
         value = str(value)
-        if not parse_ver('1.4') <= parse_ver(value):
+        if parse_ver('1.4') > parse_ver(value):
             raise ValueError()
         return value
     except (AttributeError, TypeError, ValueError):

requirements_pypi.txt

@@ -1,4 +1,4 @@
 pygcgen==0.2.4
 setuptools==41.2.0
-twine==1.13.0
+twine==2.0.0
 wheel==0.33.6

requirements_test.txt

@@ -1,6 +1,6 @@
 flake8==3.7.8
-pylint==2.3.1
-pytest==5.1.2
+pylint==2.4.2
+pytest==5.2.0
 pytest-cov==2.7.1
 pytest-sugar==0.9.2
 pytest-timeout==1.3.3

tests/test_message.py

@@ -8,6 +8,8 @@
 from mysensors.const_14 import Internal, MessageType
 from mysensors.task import SyncTasks
 
+# pylint: disable=unnecessary-comprehension
+
 PRES_FIXTURES_14 = {
     'S_DOOR': 'Front Door',
     'S_ARDUINO_NODE': '1.4',