Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary proc_open check #28

Merged
merged 1 commit into from
Dec 4, 2022
Merged

Remove unnecessary proc_open check #28

merged 1 commit into from
Dec 4, 2022

Conversation

theofidry
Copy link
Owner

I am not entirely sure why proc_open itself was checked when unused (in any implementation). I however don't think it's relevant anymore:

  • Each finder checks if the proc related functions do exist (I assume if proc_open was not there then popen was not neither).
  • In case it was not available, it was returning 1, whereas I think the NumberOfCpuCoreNotFound makes more sense.

@theofidry theofidry merged commit 7704b16 into main Dec 4, 2022
@theofidry theofidry deleted the bugfix/remove-unnecessary-proc-open branch December 4, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@theofidry