Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate HwFinder #23

Merged
merged 1 commit into from
Dec 4, 2022
Merged

Consolidate HwFinder #23

merged 1 commit into from
Dec 4, 2022

Conversation

theofidry
Copy link
Owner

  • Move the popen function check instead of relying on the CpuCoreCounter's proc_open check.
  • Refactor HwFinder::find() for better readability
  • Handle potential fgets false value returned

@theofidry theofidry merged commit 2114c6e into main Dec 4, 2022
@theofidry theofidry deleted the feature/consolidate-hw branch December 4, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@theofidry