Move checking if proc_open function exists to the executor (#92)

theofidry · Dec 16, 2022 · a29d68f · a29d68f
1 parent fcd320c
commit a29d68f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/Executor/ProcOpen.php b/src/Executor/ProcOpen.php
@@ -14,6 +14,7 @@
 namespace Fidry\CpuCoreCounter\Executor;
 
 use function fclose;
+use function function_exists;
 use function is_resource;
 use function proc_close;
 use function proc_open;
@@ -22,10 +23,14 @@
 final class ProcOpen
 {
     /**
-     * @return array{string, string} STDOUT & STDERR tuple
+     * @return array{string, string}|null STDOUT & STDERR tuple
      */
     public static function execute(string $command): ?array
     {
+        if (!function_exists('proc_open')) {
+            return null;
+        }
+
         $pipes = [];
 
         $process = @proc_open(

diff --git a/src/Finder/ProcOpenBasedFinder.php b/src/Finder/ProcOpenBasedFinder.php
@@ -63,10 +63,6 @@ public function diagnose(): string
      */
     public function find(): ?int
     {
-        if (!function_exists('proc_open')) {
-            return null;
-        }
-
         $output = ProcOpen::execute($this->getCommand());
 
         if (null === $output) {