Move the dummy core finder from the test to the source directory (#51)

tests/Finder/DummyCpuCoreFinder.php → src/Finder/DummyCpuCoreFinder.php

@@ -11,18 +11,23 @@
 
 declare(strict_types=1);
 
-namespace Fidry\CpuCoreCounter\Test\Finder;
-
-use Fidry\CpuCoreCounter\Finder\CpuCoreFinder;
+namespace Fidry\CpuCoreCounter\Finder;
 
+/**
+ * This finder returns whatever value you gave to it. This is useful for testing
+ * or as a fallback to avoid to catch the NumberOfCpuCoreNotFound exception.
+ */
 final class DummyCpuCoreFinder implements CpuCoreFinder
 {
     /**
-     * @var int|null
+     * @var positive-int
      */
     private $count;
 
-    public function __construct(?int $count)
+    /**
+     * @param positive-int $count
+     */
+    public function __construct(int $count)
     {
         $this->count = $count;
     }

src/Finder/NullCpuCoreFinder.php

@@ -0,0 +1,25 @@
+<?php
+
+/*
+ * This file is part of the Fidry CPUCounter Config package.
+ *
+ * (c) Théo FIDRY <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace Fidry\CpuCoreCounter\Finder;
+
+/**
+ * This finder returns whatever value you gave to it. This is useful for testing.
+ */
+final class NullCpuCoreFinder implements CpuCoreFinder
+{
+    public function find(): ?int
+    {
+        return null;
+    }
+}

tests/CpuCoreCounterTest.php

@@ -16,8 +16,9 @@
 use Exception;
 use Fidry\CpuCoreCounter\CpuCoreCounter;
 use Fidry\CpuCoreCounter\Finder\CpuCoreFinder;
+use Fidry\CpuCoreCounter\Finder\DummyCpuCoreFinder;
+use Fidry\CpuCoreCounter\Finder\NullCpuCoreFinder;
 use Fidry\CpuCoreCounter\NumberOfCpuCoreNotFound;
-use Fidry\CpuCoreCounter\Test\Finder\DummyCpuCoreFinder;
 use PHPUnit\Framework\TestCase;
 use function get_class;
 use function is_array;
@@ -117,7 +118,7 @@ public static function cpuCoreFinderProvider(): iterable
 
         yield 'single finder does not find a value' => [
             [
-                new DummyCpuCoreFinder(null),
+                new NullCpuCoreFinder(),
             ],
             $defaultException,
         ];
@@ -140,9 +141,9 @@ public static function cpuCoreFinderProvider(): iterable
 
             return [
                 [
-                    new DummyCpuCoreFinder(null),
+                    new NullCpuCoreFinder(),
                     $finder,
-                    new DummyCpuCoreFinder(null),
+                    new NullCpuCoreFinder(),
                     new DummyCpuCoreFinder(11),
                 ],
                 [$finder, 7],

tests/Finder/DummyCpuCoreFinderTest.php

@@ -0,0 +1,32 @@
+<?php
+
+/*
+ * This file is part of the Fidry CPUCounter Config package.
+ *
+ * (c) Théo FIDRY <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace Fidry\CpuCoreCounter\Test\Finder;
+
+use Fidry\CpuCoreCounter\Finder\DummyCpuCoreFinder;
+use PHPUnit\Framework\TestCase;
+
+/**
+ * @covers \Fidry\CpuCoreCounter\Finder\DummyCpuCoreFinder
+ *
+ * @internal
+ */
+final class DummyCpuCoreFinderTest extends TestCase
+{
+    public function test_it_returns_the_number_of_cores_given(): void
+    {
+        $finder = new DummyCpuCoreFinder(5);
+
+        self::assertSame(5, $finder->find());
+    }
+}

tests/Finder/NullCpuCoreFinderTest.php

@@ -0,0 +1,32 @@
+<?php
+
+/*
+ * This file is part of the Fidry CPUCounter Config package.
+ *
+ * (c) Théo FIDRY <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace Fidry\CpuCoreCounter\Test\Finder;
+
+use Fidry\CpuCoreCounter\Finder\NullCpuCoreFinder;
+use PHPUnit\Framework\TestCase;
+
+/**
+ * @covers \Fidry\CpuCoreCounter\Finder\NullCpuCoreFinder
+ *
+ * @internal
+ */
+final class NullCpuCoreFinderTest extends TestCase
+{
+    public function test_it_returns_null(): void
+    {
+        $finder = new NullCpuCoreFinder();
+
+        self::assertNull($finder->find());
+    }
+}