This repository has been archived by the owner on Jun 23, 2024. It is now read-only.
Allow PHP 8.0 #58
Merged
Allow PHP 8.0 #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using packages like api-platform/core as a guide I've opted to have the PHP version constraint be ">=7.3" rather than "^7.3|^8.0".
It's fine by me as there is so little code the main constraints are going to be derived from Psysh & Symfony; Would be nice to move to GitHub Actions but that can be done in another PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am attempting to use this with a code base that is using PHP 8.0 and have been able to perform some very minor smoke testing locally.
I've opted to set the version constraint to ">=7.3" rather than "^7.3|^8.0", using packages like api-platform/core as a guide, though this is certainly up for discussion.