Skip to content
This repository has been archived by the owner on Jun 23, 2024. It is now read-only.

Use the test.xml of the FrameworkBundle #47

Merged
merged 1 commit into from
Mar 25, 2020

Conversation

maxhelias
Copy link

No description provided.

@theofidry
Copy link
Owner

I don't remember this PR at all: is it still relevant in which case can this be updated?

@maxhelias
Copy link
Author

maxhelias commented Feb 12, 2020

Hi! Don't worry me too 😅
I think yes, this will allow us to follow the test configuration of Symfony, to warn us in case of BC or avoid late duplication

@theofidry
Copy link
Owner

Guess I have trouble with this PR :(

So if I understand correctly Psysh will use the test container instead of the regular one allowing to access to services that might otherwise get inlined in the regular container is that right?

Is that test container available in dev as well?

@theofidry theofidry merged commit b06dd86 into theofidry:master Mar 25, 2020
@theofidry
Copy link
Owner

Tested locally, looks good. Thanks! :)

@maxhelias
Copy link
Author

@theofidry This is correct for the first one and it will follow the evolution of Symfony.

And I don't think it's available in dev because it's only available with the framework.test: true option

@maxhelias maxhelias deleted the config branch March 25, 2020 23:59
@theofidry
Copy link
Owner

Seems to be working fine in dev as well

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants