Gds upgrade 7.14.0 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At present, only Expires headers are used to set the cache length period for a request. This modifies the `response_cache_time` method to look for a `Cache-control` header in the first instance, and then fall back to the `Expires` header if it is not present or does not contain a `max-age` or `no-cache` directive.
Oh ActiveSupport `present?`, where art thou?
Changes in this release: - alphagov#82: respect Cache-Control headers in the JSON client. - alphagov#83: Add method to request all needs to Need API client
Fix NameError occuring when using extend Forwardable outside Bundler
The message of an exception is defined as a string. This was JSON parsing the body, and passing the hash to the exception which called to_s on it. The result wasn't particularly useful. This now stores the parsed JSON data in an error_details attribute on the exception, and puts the raw http_body in the message.
This makes it consistent with put_json, post_json, and is the expected behaviour given the method name.
Adds support for the Router API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's important to note here, is that this is the point that the router api got added.
Still nothing that odi uses, so should still be safe.