-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend screening overlap to IOData wrapper #171
Extend screening overlap to IOData wrapper #171
Conversation
gbasis/wrappers.py
Outdated
"""Return basis set stored within the `IOData` instance in `iodata`. | ||
|
||
Parameters | ||
---------- | ||
mol : iodata.iodata.IOData | ||
`IOData` instance from `iodata` module. | ||
tol : float | ||
Tolerance used in overlap screening. | ||
ovrlap : bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo to fix here ("ovrlap" should be "overlap").
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
@leila-pujal, this looks good to me. The only thing I might suggest is updating the documentation of the |
Thanks @maximilianvz for your detailed and quick review. I overlooked that typo (probably because in some other places the abbreviation is used). You are right about the mismatch in the documentation. I address it in my last commit as well as the typo (like you suggested). I've asked for another revision from you. Let me know if I forgot to address something from your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now, @leila-pujal.
This PR builds on top of PR #111 to extend the screening overlap functionality to data load from and
IOData
object. PR #111 implemented the screening of overlap type integrals. This feature is set up at the user level when the functionmake_contractions
is employed in combination with a parsed basis from a Gaussian or NWChem basis set. The same API is added to the functionfrom_iodata
to be able to access the overlap screening feature.test_wrappers.py
has been updated and also a new test has been added to check the new API correctly stores the overlap screening information passed when instantiating eachGeneralizedContractionShell
Checklist
Type of Changes
Related