Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add typescript definitions #31

Merged
merged 9 commits into from
Apr 26, 2020
Merged

feat: add typescript definitions #31

merged 9 commits into from
Apr 26, 2020

Conversation

ForbesLindesay
Copy link
Member

No description provided.

@rollingversions
Copy link

rollingversions bot commented Apr 26, 2020

Change Log for is-promise (2.2.2 → 3.0.0)

Breaking Changes

  • This package now comes bundled with TypeScript definitions

    This means you may get new errors that you didn't see before if you are using TypeScript. If you are not using TypeScript, this change will not impact you.

Edit changelog

@ForbesLindesay
Copy link
Member Author

@mvila would you be able to give this a quick look to sanity check what I've done? As with all these small libraries, it feels like 90% of the work is writing the tests.

@LarryBattle
Copy link

LarryBattle commented Apr 26, 2020

Even though it might be redundant, could you add a test for Promise.resolve()?

assert(isPromise(Promise.resolve()) === true);

@mvila
Copy link

mvila commented Apr 26, 2020

Thanks, @ForbesLindesay! It all sounds good to me.

@ForbesLindesay ForbesLindesay merged commit 19c6d89 into master Apr 26, 2020
@ForbesLindesay ForbesLindesay deleted the feat/typescript branch April 26, 2020 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants