-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add typescript definitions #31
Conversation
Change Log for is-promise (2.2.2 → 3.0.0)Breaking Changes
|
@mvila would you be able to give this a quick look to sanity check what I've done? As with all these small libraries, it feels like 90% of the work is writing the tests. |
Even though it might be redundant, could you add a test for Promise.resolve()? assert(isPromise(Promise.resolve()) === true); |
Thanks, @ForbesLindesay! It all sounds good to me. |
No description provided.