UpdateSummaryVar improvements #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no benefit to padding the last field with spaces. Additionally this fixes a bug that is caused because nothing is output if the message's datatype is MOOS_NOT_SET which causes the ss<<std::left<<std::setw(20); to get applied to the ss<<"\n"; statement resulting in padding at the start of the next line of output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a bug where channels with message type of MOOS_NOT_SET caused the next line in the message to be indented by 19 spaces.
It also removes some unreachable code and removes the trailing whitespace on the end of lines which aren't for channels with string content that is 20 or more characters long.