-
-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(theme): improving component customization using twMerge #800
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #800 +/- ##
=======================================
Coverage 99.54% 99.54%
=======================================
Files 129 163 +34
Lines 6539 6621 +82
Branches 391 401 +10
=======================================
+ Hits 6509 6591 +82
Misses 30 30
☔ View full report in Codecov by Sentry. |
04aa4a2
to
fd6c964
Compare
3e609c1
to
a303dac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also do me a favor and replace the classnames
usage in app/components/code-preview.tsx
and app/docs/layout.tsx
to tailwind-merge
?
Moved to #816 |
Description
Users normally get confused about the need to use
!
to overwrite the theme classes when usingclassName=
property. This PR includestailwind-merge
that handles the conflicts instead of usingclassNames
.Example:
What this PR does:
Current state:
Fixes # (issue)
Type of change
Breaking changes
classname
library and introducing thetailwind-merge
it means that theme-per-component will not require to use!important
anymore, the same applies toclassName
prop.FlowbiteAvatarImageTheme
now has abase
style.How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
N/A
Checklist: