Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component): Use theme in ListGroups, resolves #137 #203

Merged
merged 4 commits into from
Jun 8, 2022

Conversation

tulup-conner
Copy link
Collaborator

Breaking changes

You can now theme ListGroups with <Flowbite theme={..}>:

listGroup: {
  base: string;
  item: {
    active: FlowbiteBoolean;
    base: string;
    href: FlowbiteBoolean;
    icon: string;
  };
};

Features

Tests

Unit

@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #203 (8fcd9f2) into main (9cd1eab) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
+ Coverage   98.92%   98.94%   +0.01%     
==========================================
  Files         127      127              
  Lines        7277     7407     +130     
  Branches      826      851      +25     
==========================================
+ Hits         7199     7329     +130     
  Misses         78       78              
Impacted Files Coverage Δ
src/lib/components/ListGroup/ListGroup.spec.tsx 100.00% <100.00%> (ø)
src/lib/components/ListGroup/ListGroupItem.tsx 100.00% <100.00%> (ø)
src/lib/components/ListGroup/index.tsx 100.00% <100.00%> (ø)
src/lib/theme/default.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cd1eab...8fcd9f2. Read the comment docs.

@tulup-conner tulup-conner requested a review from rluders June 6, 2022 10:08
@tulup-conner tulup-conner marked this pull request as ready for review June 6, 2022 10:09
@tulup-conner tulup-conner self-assigned this Jun 7, 2022
@rluders rluders merged commit 360a723 into themesberg:main Jun 8, 2022
@tulup-conner tulup-conner deleted the feat/list-group-theme branch June 8, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants