Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component): Use FlowbiteTheme in Sidebars, resolves #143 #200

Merged
merged 5 commits into from
Jun 8, 2022

Conversation

tulup-conner
Copy link
Collaborator

@tulup-conner tulup-conner commented Jun 6, 2022

Breaking changes

Sidebars can now be customized via <Flowbite theme={..}>.

sidebar: {
    base: string;
    collapsed: FlowbiteBoolean;
    inner: string;
    collapse: {
      button: string;
      icon: {
        base: string;
        open: FlowbiteBoolean;
      };
      label: {
        base: string;
        icon: string;
      };
      list: string;
    };
    cta: {
      base: string;
      color: SidebarCTAColors;
    };
    item: {
      active: FlowbiteBoolean;
      base: string;
      collapsed: {
        insideCollapse: string;
      };
      content: {
        base: string;
        collapsed: string;
      };
      icon: {
        base: string;
        active: string;
      };
    };
    items: string;
    itemGroup: string;
    logo: {
      base: string;
      collapsed: FlowbiteBoolean;
      img: string;
    };
  };

Features

Tests

Unit

@tulup-conner tulup-conner changed the title feat(component): Use FlowbiteTheme in Sidebar.* feat(component): Use FlowbiteTheme in Sidebars Jun 6, 2022
@tulup-conner tulup-conner force-pushed the feat/sidebar-theme branch 2 times, most recently from e0615c9 to 8aead1c Compare June 6, 2022 08:27
@tulup-conner tulup-conner marked this pull request as ready for review June 6, 2022 08:33
@tulup-conner tulup-conner requested a review from rluders June 6, 2022 08:35
@tulup-conner tulup-conner changed the title feat(component): Use FlowbiteTheme in Sidebars feat(component): Use FlowbiteTheme in Sidebars, resolves #143 Jun 6, 2022
@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #200 (de25b38) into main (9ccf0c2) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
+ Coverage   98.95%   98.99%   +0.04%     
==========================================
  Files         127      127              
  Lines        7459     7765     +306     
  Branches      863      905      +42     
==========================================
+ Hits         7381     7687     +306     
  Misses         78       78              
Impacted Files Coverage Δ
src/lib/components/Sidebar/Sidebar.spec.tsx 100.00% <100.00%> (ø)
src/lib/components/Sidebar/SidebarCTA.tsx 100.00% <100.00%> (ø)
src/lib/components/Sidebar/SidebarCollapse.tsx 100.00% <100.00%> (ø)
src/lib/components/Sidebar/SidebarItem.tsx 100.00% <100.00%> (ø)
src/lib/components/Sidebar/SidebarItemGroup.tsx 100.00% <100.00%> (ø)
src/lib/components/Sidebar/SidebarItems.tsx 100.00% <100.00%> (ø)
src/lib/components/Sidebar/SidebarLogo.tsx 100.00% <100.00%> (ø)
src/lib/components/Sidebar/index.tsx 100.00% <100.00%> (ø)
src/lib/theme/default.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ccf0c2...de25b38. Read the comment docs.

@tulup-conner tulup-conner self-assigned this Jun 7, 2022
@rluders rluders linked an issue Jun 8, 2022 that may be closed by this pull request
@rluders rluders self-requested a review June 8, 2022 07:45
```js
sidebar: {
    base: string;
    collapsed: FlowbiteBoolean;
    inner: string;
    collapse: {
      button: string;
      icon: {
        base: string;
        open: FlowbiteBoolean;
      };
      label: {
        base: string;
        icon: string;
      };
      list: string;
    };
    cta: {
      base: string;
      color: SidebarCTAColors;
    };
    item: {
      active: FlowbiteBoolean;
      base: string;
      collapsed: {
        insideCollapse: string;
      };
      content: {
        base: string;
        collapsed: string;
      };
      icon: {
        base: string;
        active: string;
      };
    };
    items: string;
    itemGroup: string;
    logo: {
      base: string;
      collapsed: FlowbiteBoolean;
      img: string;
    };
  };
```
This is deprecated behavior.
The `Sidebar` examples need a non-standard background
color.
@rluders rluders merged commit 59654eb into themesberg:main Jun 8, 2022
@tulup-conner tulup-conner deleted the feat/sidebar-theme branch June 10, 2022 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theme: Sidebar component
2 participants