-
-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(component): Use FlowbiteTheme
in Sidebar
s, resolves #143
#200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tulup-conner
force-pushed
the
feat/sidebar-theme
branch
from
June 6, 2022 07:19
589eed5
to
5a04be8
Compare
tulup-conner
changed the title
feat(component): Use
feat(component): Use Jun 6, 2022
FlowbiteTheme
in Sidebar.*
FlowbiteTheme
in Sidebar
s
tulup-conner
force-pushed
the
feat/sidebar-theme
branch
2 times, most recently
from
June 6, 2022 08:27
e0615c9
to
8aead1c
Compare
tulup-conner
changed the title
feat(component): Use
feat(component): Use Jun 6, 2022
FlowbiteTheme
in Sidebar
sFlowbiteTheme
in Sidebar
s, resolves #143
tulup-conner
force-pushed
the
feat/sidebar-theme
branch
from
June 6, 2022 11:07
8aead1c
to
a98e76f
Compare
Codecov Report
@@ Coverage Diff @@
## main #200 +/- ##
==========================================
+ Coverage 98.95% 98.99% +0.04%
==========================================
Files 127 127
Lines 7459 7765 +306
Branches 863 905 +42
==========================================
+ Hits 7381 7687 +306
Misses 78 78
Continue to review full report at Codecov.
|
rluders
approved these changes
Jun 8, 2022
```js sidebar: { base: string; collapsed: FlowbiteBoolean; inner: string; collapse: { button: string; icon: { base: string; open: FlowbiteBoolean; }; label: { base: string; icon: string; }; list: string; }; cta: { base: string; color: SidebarCTAColors; }; item: { active: FlowbiteBoolean; base: string; collapsed: { insideCollapse: string; }; content: { base: string; collapsed: string; }; icon: { base: string; active: string; }; }; items: string; itemGroup: string; logo: { base: string; collapsed: FlowbiteBoolean; img: string; }; }; ```
This is deprecated behavior.
The `Sidebar` examples need a non-standard background color.
tulup-conner
force-pushed
the
feat/sidebar-theme
branch
from
June 8, 2022 08:26
a98e76f
to
de25b38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes
Sidebar
s can now be customized via<Flowbite theme={..}>
.Features
Tests
Unit