-
-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): build step + improve DX #1336
Conversation
🦋 Changeset detectedLatest commit: d5a49c9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThe recent updates encompass a series of enhancements and bug fixes across various components, focusing on improving the build process, developer experience, and updating dependencies. Notably, patches have been applied to Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Review Status
Configuration used: CodeRabbit UI
Files ignored due to path filters (1)
bun.lockb
is excluded by!bun.lockb
Files selected for processing (10)
- .changeset/fuzzy-ravens-type.md (1 hunks)
- .changeset/old-flies-shop.md (1 hunks)
- .github/actions/setup/action.yml (1 hunks)
- .gitignore (1 hunks)
- apps/storybook/package.json (1 hunks)
- apps/web/package.json (1 hunks)
- package.json (2 hunks)
- packages/cli/package.json (2 hunks)
- packages/ui/package.json (2 hunks)
- packages/ui/tsconfig.build.json (1 hunks)
Additional Context Used
Additional comments not posted (15)
.gitignore (1)
6-6
: The addition of*.backup
to the.gitignore
file is a good practice to keep the repository clean from unnecessary files.packages/ui/tsconfig.build.json (2)
5-5
: Enabling source maps is a positive change for debugging purposes.
9-9
: Ensure that changing the exclude directory fromdist
tolib
aligns with the overall project structure and build configuration.Verification successful
The verification process has confirmed that a
lib
directory does not exist withinpackages/ui
. This means that changing the exclude directory fromdist
tolib
in the TypeScript build configuration does not impact the inclusion of any TypeScript files within thepackages/ui
directory, as there are no files within a non-existentlib
directory to exclude.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify that no important files in 'lib' are unintentionally excluded from the TypeScript build process. fd '.*\.ts' packages/ui --exec grep -L 'lib/'Length of output: 15566
Script:
#!/bin/bash # Check if a 'lib' directory exists within 'packages/ui' and list its contents if it does. if [ -d "packages/ui/lib" ]; then echo "'lib' directory exists within 'packages/ui'. Listing contents:" find "packages/ui/lib" -type f \( -name "*.ts" -o -name "*.tsx" \) else echo "'lib' directory does not exist within 'packages/ui'." fiLength of output: 155
.github/actions/setup/action.yml (1)
10-10
: Updating to Bun version1.1.0
aligns with the PR's objective of using modern tooling. Ensure compatibility with the project's existing setup and workflows.apps/storybook/package.json (1)
18-34
: Updating dependencies to their latest versions is a good practice. Ensure compatibility and test the Storybook setup thoroughly after these updates.apps/web/package.json (1)
24-43
: Updating dependencies to their latest versions is beneficial for maintaining project health. Ensure compatibility and test the web app setup thoroughly after these updates.package.json (2)
24-24
: Adding apostinstall
script to run"bun build:ui"
can streamline setup processes. Ensure it integrates well with existing workflows.
37-50
: Updating dependencies and switching thepackageManager
to[email protected]
aligns with the PR's objectives. Verify the impact on existing workflows and compatibility.packages/cli/package.json (3)
56-56
: Updated TypeScript to version 5.4.3.Please ensure compatibility with the rest of the project's codebase and other dependencies.
65-70
: Added areplace
configuration inclean-package
to restore thepostpublish
script after publishing.This is a good practice for managing temporary changes made for the publishing process, ensuring the repository remains clean and necessary scripts are restored post-publish.
52-72
: > 📝 NOTEThis review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-70]
The
postpack
script was removed according to the summary.Please verify the impact of this removal on the package's build or publish process to ensure it does not introduce any unintended consequences.
packages/ui/package.json (4)
24-24
: Changed the path for types in exports to./lib/types/index.d.ts
.Organizing TypeScript declaration files into a specific folder and updating their paths in the
exports
field improves project organization and makes it easier for developers to locate type definitions.
42-48
: Updated build scripts to optimize the build process and added a new build scriptbuild:fast
.These changes indicate a focus on improving the build process's efficiency. Please ensure these scripts are correctly integrated into the project's build pipeline and do not introduce any issues.
61-83
: Updated dependency versions to their latest.Please ensure compatibility with the project's codebase and other dependencies to avoid introducing any compatibility issues.
95-100
: Modified theclean-package
configuration to include areplace
section for restoring thepostpublish
script after publishing.This is a good practice for managing temporary changes made for the publishing process, ensuring the repository remains clean and necessary scripts are restored post-publish.
79b666b
to
d5a49c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Status
Configuration used: CodeRabbit UI
Files ignored due to path filters (1)
bun.lockb
is excluded by!bun.lockb
Files selected for processing (10)
- .changeset/fuzzy-ravens-type.md (1 hunks)
- .changeset/old-flies-shop.md (1 hunks)
- .github/actions/setup/action.yml (1 hunks)
- .gitignore (1 hunks)
- apps/storybook/package.json (1 hunks)
- apps/web/package.json (1 hunks)
- package.json (2 hunks)
- packages/cli/package.json (2 hunks)
- packages/ui/package.json (2 hunks)
- packages/ui/tsconfig.build.json (1 hunks)
Files skipped from review as they are similar to previous changes (8)
- .github/actions/setup/action.yml
- .gitignore
- apps/storybook/package.json
- apps/web/package.json
- package.json
- packages/cli/package.json
- packages/ui/package.json
- packages/ui/tsconfig.build.json
Additional Context Used
Additional comments not posted (2)
.changeset/fuzzy-ravens-type.md (1)
5-5
: Consider starting the sentence with an uppercase letter for consistency and readability.- fix `clean-package` flow + Fix `clean-package` flow.changeset/old-flies-shop.md (1)
5-5
: Consider starting the sentence with an uppercase letter for consistency and readability.- fix build step, export types and improve DX + Fix build step, export types and improve DX
Changes
dev
command inpackages/ui
postinstall
script top level*.d.ts
files intotypes
folder"type": "module"
frompackage.json
in cccda3e commitIssues
#1326, #1327, #1329
Summary by CodeRabbit
Bug Fixes
create-flowbite-react
to enhance theclean-package
flow.flowbite-react
.Chores
bun-version
in GitHub Actions setup for better performance..gitignore
to exclude*.backup
files.apps/storybook
andweb
packages for enhanced functionality and security.postinstall
script and updated dependencies in the mainpackage.json
.Documentation
New Features
Refactor
clean-package
in multiple packages for streamlined development processes.Style
Tests
Revert