fix: polymorphic component return types [button, dropdown item]

[SutuSebastian]

• I have followed the Your First Code Contribution section of the Contributing guide

Changes

• fix Button and DropdownItem being rendered as React.ReactNode | null - now returns JSX.Element
• fix incorrect import from '~/src/helpers/generic-as-prop' to '../../helpers/generic-as-prop'

Issues

#962

Result

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
flowbite-react	❌ Failed (Inspect)			Mar 20, 2024 2:52pm

[coderabbitai]

Warning

Rate Limit Exceeded

@SutuSebastian has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 10 minutes and 49 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between d35a009 and 7c5847c.

Walkthrough

This update involves refactoring and optimizing component structures within a React project. Specifically, it refines the Button component by renaming ButtonComponentFn to ButtonComponent, adjusting type definitions, and updating export structures. These changes aim to streamline the component definition and export configuration for improved code organization and maintainability.

Changes

File Path	Change Summary
src/components/Button/Button.tsx	Refactored ButtonComponentFn into ButtonComponent, adjusted type definitions and exports.

Related issues

• Button as links do not have hover states #1086: The refactoring and improved type definitions for the Button component may indirectly contribute to achieving consistent hover state behavior across buttons and links by enabling more precise control over component properties and behaviors.

🐇✨
Changes are afoot, in components so bright,
Where buttons and dropdowns now see the light.
A rabbit hopped through, code in its trail,
Leaving behind a more elegant tale.
So here's to the devs, with their craft so keen,
🎉 May your code be robust, and your errors unseen!
✨🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[SutuSebastian]

Note: vercel preview will fail, due to changed settings for the new monorepo structure.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 60aa2f4 and 60ec86c.

Files selected for processing (2)

• src/components/Button/Button.tsx (2 hunks)
• src/components/Dropdown/DropdownItem.tsx (2 hunks)

Additional comments: 5

src/components/Dropdown/DropdownItem.tsx (2)

• 28-30: The refinement of DropdownItemComponentType to specify the props parameter more explicitly and adjust the return type to JSX.Element is a positive change, enhancing type safety and clarity.
• 25-35: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [32-65]

The implementation of the DropdownItem component correctly utilizes forwardRef, generics, and context management. The handling of custom themes and conditional rendering of icons is well done. This aligns with best practices for React component development.

src/components/Button/Button.tsx (3)

• 91-93: The adjustment of ButtonComponentType to ensure a more precise and consistent type definition is a positive change, enhancing type safety and clarity.
• 88-98: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [95-171]

The implementation of the ButtonComponent correctly utilizes forwardRef, generics, and theme management. The handling of a wide range of props for customization and conditional class name generation is well done. This aligns with best practices for React component development.

• 175-175: The export structure of the Button component, with the Group property attached, follows a common pattern for component libraries, promoting a cleaner API surface.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 60ec86c and d35a009.

Files selected for processing (1)

• src/components/Button/Button.tsx (4 hunks)

Files skipped from review as they are similar to previous changes (1)

• src/components/Button/Button.tsx

[nigellima]

LGTM

Tested locally

[SutuSebastian]

LGTM

Tested locally

same, looks good to me

[rnicholus]

0.7.4 is completely broken. npm install [email protected] pulls down a total of 3 files: LICENSE, README.md, and package.json.

[SutuSebastian]

0.7.4 is completely broken. npm install [email protected] pulls down a total of 3 files: LICENSE, README.md, and package.json.

Fixing.

[SutuSebastian]

0.7.4 is completely broken. npm install [email protected] pulls down a total of 3 files: LICENSE, README.md, and package.json.

Check 0.7.5.

[rnicholus]

thanks!