fix(Modal): modal scrollbar overflow style issue fixed #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #769 +/- ##
=======================================
Coverage 99.54% 99.54%
=======================================
Files 129 129
Lines 6537 6537
Branches 391 391
=======================================
Hits 6507 6507
Misses 30 30
☔ View full report in Codecov by Sentry. |
|
My pleasure.
When we will be releasing this fix to the production ?
…On Sat, 27 May 2023, 1:45 am Conner Davis, ***@***.***> wrote:
***@***.**** approved this pull request.
Thank you!
—
Reply to this email directly, view it on GitHub
<#769 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMWPISEJR3JIRI4Z5EUEVF3XIEI7PANCNFSM6AAAAAAYQBPKJQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@Alreadywinner You can use this now on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Flowbite modal removes the scroll bar forever if I toggle it from Flowbite footer component.
Fixes # 761
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I tested this change by running the documentation site locally and toggling the Modal from the bottom works fine from my end the scrollbar doesn't remain hidden when I close the Modal
Checklist: