ScrollBar issue if we toggle it from bottom of the screen #761
Comments
tulup-conner
added
🐛 bug
|
Thank you. I can confirm this behavior and the cause is here: https://github.com/themesberg/flowbite-react/blob/main/src/components/Modal/Modal.tsx#L126 We have an open PR that will fix this in 1.0.0, but I would be happy to introduce this in an earlier release, since it's just a bug fix. If you're able to, it would be great if you could open a PR that literally just replaces that line by |
|
Yeah sure I would love to solve this issue one more thing how to set up the
library ? I mean should I clone it and then make a change ?
…On Fri, 26 May 2023, 9:46 am Conner Davis, ***@***.***> wrote:
Thank you. I can confirm this behavior and the cause is here:
https://github.com/themesberg/flowbite-react/blob/main/src/components/Modal/Modal.tsx#L126
We have an open PR that will fix this in 1.0.0, but I would be happy to
introduce this in an earlier release, since it's just a bug fix. If you're
able to, it would be great if you could open a PR that literally just
replaces that line by 'hidden' : ''.
—
Reply to this email directly, view it on GitHub
<#761 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMWPISHHOGOPN7L4FTPTDZTXIAYTNANCNFSM6AAAAAAYOQB3EM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
You can assign it to me will do it in couple of hours
…On Fri, 26 May 2023, 11:17 am Waseel Fawad, ***@***.***> wrote:
Yeah sure I would love to solve this issue one more thing how to set up
the library ? I mean should I clone it and then make a change ?
On Fri, 26 May 2023, 9:46 am Conner Davis, ***@***.***>
wrote:
> Thank you. I can confirm this behavior and the cause is here:
> https://github.com/themesberg/flowbite-react/blob/main/src/components/Modal/Modal.tsx#L126
>
> We have an open PR that will fix this in 1.0.0, but I would be happy to
> introduce this in an earlier release, since it's just a bug fix. If you're
> able to, it would be great if you could open a PR that literally just
> replaces that line by 'hidden' : ''.
>
> —
> Reply to this email directly, view it on GitHub
> <#761 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AMWPISHHOGOPN7L4FTPTDZTXIAYTNANCNFSM6AAAAAAYOQB3EM>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
|
Check out the contributing guide: https://www.flowbite-react.com/docs/getting-started/contributing |
|
Thanks a lot I will do it today and let you know so that you can review the
code
…On Fri, 26 May 2023, 12:00 pm Conner Davis, ***@***.***> wrote:
Assigned #761 <#761>
to @Alreadywinner <https://github.com/Alreadywinner>.
—
Reply to this email directly, view it on GitHub
<#761 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMWPISDC2XD76IRYFLRST3LXIBIHDANCNFSM6AAAAAAYOQB3EM>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
1 task
|
@tulup-conner pull request is made and ready for review |
|
Fixed And Now it's working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Flowbite modal removes the scroll bar forever if I toggle it from Flowbite footer component
To Reproduce
Steps to reproduce the behavior:
Expected behavior
If I open the Modal it should hide the main scrollbar smoothly as it is doing but on closing the Modal it should display the scrollbar again.
Screenshots
Scroll to footer and Press on pressing terms and Condition button :
Modal Appears and Scrollbar is hidden:
Now on pressing cross icon the scrollbar remains hidden
System information:
Project information:
Additional context
On Inspecting I found out that
overflow:hiddenproperty gets applied when I open up the modal, and on closing the modal the<body />tag have the propertyoverflow:autowith it I think this should not happenThe text was updated successfully, but these errors were encountered: