Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<Accordion.Content>s can't be closed once expanded #618

Closed
tulup-conner opened this issue Feb 21, 2023 · 0 comments
Closed

<Accordion.Content>s can't be closed once expanded #618

tulup-conner opened this issue Feb 21, 2023 · 0 comments
Labels
🐛 bug Something isn't working confirmed This bug was confirmed

Comments

@tulup-conner
Copy link
Collaborator

tulup-conner commented Feb 21, 2023 •
edited
Loading

Describe the bug
You can't click the close button on the active (currently open) <Accordion.Content>.

Expected behavior
You should be able to also close the active item which will just leave the <Accordion> with all items collapsed.
@tulup-conner tulup-conner added 🐛 bug Something isn't working confirmed This bug was confirmed labels Feb 21, 2023
@tulup-conner tulup-conner added this to the 0.4.0 milestone Feb 21, 2023
@tulup-conner tulup-conner self-assigned this Feb 21, 2023
@tulup-conner tulup-conner mentioned this issue Feb 21, 2023
Closed
@tulup-conner tulup-conner changed the title <Accordion.Item>s can't be closed once expanded <Accordion.Content>s can't be closed once expanded Mar 1, 2023
@tulup-conner tulup-conner removed this from the 0.4.0 milestone Mar 1, 2023
@tulup-conner tulup-conner added the help wanted Extra attention is needed label Mar 4, 2023
@tulup-conner tulup-conner removed their assignment Mar 4, 2023
mufasubhai pushed a commit to mufasubhai/flowbite-react that referenced this issue Mar 12, 2023
fix(accordion.tsx): fixed bug where Accordion.Content would not close…
8be0ccd 
… after being opened

Accordion content can now be closed and opened leaving all items collapsed.

themesberg#618
@mufasubhai mufasubhai mentioned this issue Apr 2, 2023
Closed
11 tasks
rluders pushed a commit that referenced this issue Apr 19, 2023
@mufasubhai
fix(components/accordion): allow opened panel to be closed #684 - add…
7de751e 
… accordion tests (#705)

* fix(accordion.tsx): fixed bug where Accordion.Content would not close after being opened

Accordion content can now be closed and opened leaving all items collapsed.

#618

* style(accordion.tsx): update spacing after adding toggleOpen function

* test(accordion.spec.tsx): add tests for accordion click to toggle

#684

* style(accordion.spec): prettier

* style(accordion.tsx): change conditional to ternary for toggleOpen

* style(accordion.tsx): prettier update for cloneElement format

---------

Co-authored-by: Adrian Apodaca <[email protected]>
@tulup-conner tulup-conner removed the help wanted Extra attention is needed label May 4, 2023
@rluders rluders closed this as completed Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working confirmed This bug was confirmed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(components/accordion): allow opened panel to be closed mufasubhai/flowbite-react
2 participants
@rluders @tulup-conner