Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button as a link error #1107

Closed
mnakhli opened this issue Nov 5, 2023 · 3 comments · Fixed by #1244
Closed

Button as a link error #1107

mnakhli opened this issue Nov 5, 2023 · 3 comments · Fixed by #1244
Labels
needs info Further information is requested

Comments

@mnakhli
Copy link

mnakhli commented Nov 5, 2023

When I use the button as a link, I get an error:
Screenshot 1402-08-14 at 16 13 55

I proceeded exactly according to the documentation.
@rluders
Copy link
Collaborator

rluders commented Nov 7, 2023

@mnakhli version?

@rluders rluders added the needs info Further information is requested label Nov 21, 2023
@jonny-ibdr
Copy link

Duplicate of #1002

@tulup-conner tulup-conner closed this as not planned Won't fix, can't repro, duplicate, stale Dec 14, 2023
@dima-kov
Copy link

any updates on this?

nigellima added a commit to gistia/flowbite-react that referenced this issue Jan 24, 2024
@nigellima
fix(button): correctly infer type from as prop
38bd24f 
`as` prop was throwing TS errors when using Next Link component. Now this correctly infers the type
from any component passed to the `as` prop

fix themesberg#1002 fix themesberg#1107
@nigellima nigellima mentioned this issue Jan 24, 2024
Merged
1 task
SutuSebastian pushed a commit that referenced this issue Jan 24, 2024
@nigellima
fix(button): Fixed Typescript error when using Next.js Link in the bu…
a6698d4 
…tton `as` prop (#1244)

* fix(button): correctly infer type from `as` prop

`as` prop was throwing TS errors when using Next Link component. Now this correctly infers the type
from any component passed to the `as` prop

fix #1002 fix #1107

* fix(dropdown-item): applied the generic types to DropdownItem and also wraps it with a forwardRef

* docs(button): removed now-unnecessary @ts-expect-error comments

* fix(button): replaced use of old genericForwardRef
abdulbasithqb pushed a commit to abdulbasithqb/flowbite-react that referenced this issue Jan 31, 2024
@nigellima @abdulbasithqb
fix(button): Fixed Typescript error when using Next.js Link in the bu…
b1058e0 
…tton `as` prop (themesberg#1244)

* fix(button): correctly infer type from `as` prop

`as` prop was throwing TS errors when using Next Link component. Now this correctly infers the type
from any component passed to the `as` prop

fix themesberg#1002 fix themesberg#1107

* fix(dropdown-item): applied the generic types to DropdownItem and also wraps it with a forwardRef

* docs(button): removed now-unnecessary @ts-expect-error comments

* fix(button): replaced use of old genericForwardRef
abdulbasithqb pushed a commit to abdulbasithqb/flowbite-react that referenced this issue Jan 31, 2024
@nigellima @abdulbasithqb
fix(button): Fixed Typescript error when using Next.js Link in the bu…
475b086 
…tton `as` prop (themesberg#1244)

* fix(button): correctly infer type from `as` prop

`as` prop was throwing TS errors when using Next Link component. Now this correctly infers the type
from any component passed to the `as` prop

fix themesberg#1002 fix themesberg#1107

* fix(dropdown-item): applied the generic types to DropdownItem and also wraps it with a forwardRef

* docs(button): removed now-unnecessary @ts-expect-error comments

* fix(button): replaced use of old genericForwardRef
@rluders rluders mentioned this issue Mar 19, 2024
Closed
@github-actions github-actions bot mentioned this issue Mar 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs info Further information is requested
Projects
None yet
Milestone
No milestone
5 participants
@rluders @dima-kov @mnakhli @tulup-conner @jonny-ibdr