Load stylesheets in the same order as when they were in the head #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolguy1771
referenced
this pull request
in coolguy1771/home-ops
Aug 23, 2023
…3198) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/onedr0p/theme-park](https://togithub.com/GilbN/theme.park) | patch | `1.13.10` -> `1.13.11` | --- ### Release Notes <details> <summary>GilbN/theme.park (ghcr.io/onedr0p/theme-park)</summary> ### [`v1.13.11`](https://togithub.com/ThemeParkTycoon/theme.park/releases/tag/1.13.11) [Compare Source](https://togithub.com/GilbN/theme.park/compare/1.13.10...1.13.11) <!-- Release notes generated using configuration in .github/release.yml at master --> ### New - 🚀 [Add script for loading unraid themes locally](https://togithub.com/GilbN/theme.park/pull/507/commits/d852434b45023f75382f2f757534afd1f95d7926) ### Fixes - 💄[Add support for latest transmission](https://togithub.com/GilbN/theme.park/pull/507/commits/8b8406f3103e76e23afecb463cf98f4cbb2367de) - 💄[Load servarr mod stylesheets in the same order as when they were in the head](https://togithub.com/GilbN/theme.park/pull/507/commits/a6df7ca39d0ec32ee457ed5e2986c5040579745d) - 💄[Update gitea themes for 1.20](https://togithub.com/GilbN/theme.park/pull/507/commits/9850f655ed61cdee7b48ee6b3dbac76fe80ea362) ### Other - [Update mods workflow ](https://togithub.com/GilbN/theme.park/pull/507/commits/2f86f4a35ba6f28345e99b41ae7dba48ef084b5f) #### New Contributors - [@​zb140](https://togithub.com/zb140) made their first contribution in [https://github.com/GilbN/theme.park/pull/503](https://togithub.com/GilbN/theme.park/pull/503) - [@​aceArt-GmbH](https://togithub.com/aceArt-GmbH) made their first contribution in [https://github.com/GilbN/theme.park/pull/506](https://togithub.com/GilbN/theme.park/pull/506) - [@​ArchGryphon9362](https://togithub.com/ArchGryphon9362) made their first contribution in [https://github.com/GilbN/theme.park/pull/505](https://togithub.com/GilbN/theme.park/pull/505) **Full Changelog**: themepark-dev/theme.park@1.13.10...1.13.11 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41Ni4xIiwidXBkYXRlZEluVmVyIjoiMzYuNTYuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: lumiere-bot <98047013+lumiere-bot[bot]@users.noreply.github.com>
szinn
referenced
this pull request
in szinn/k8s-homelab
Aug 25, 2023
…2278) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/onedr0p/theme-park](https://togithub.com/GilbN/theme.park) | patch | `1.13.10` -> `1.13.11` | --- ### Release Notes <details> <summary>GilbN/theme.park (ghcr.io/onedr0p/theme-park)</summary> ### [`v1.13.11`](https://togithub.com/ThemeParkTycoon/theme.park/releases/tag/1.13.11) [Compare Source](https://togithub.com/GilbN/theme.park/compare/1.13.10...1.13.11) <!-- Release notes generated using configuration in .github/release.yml at master --> ### New - 🚀 [Add script for loading unraid themes locally](https://togithub.com/GilbN/theme.park/pull/507/commits/d852434b45023f75382f2f757534afd1f95d7926) ### Fixes - 💄[Add support for latest transmission](https://togithub.com/GilbN/theme.park/pull/507/commits/8b8406f3103e76e23afecb463cf98f4cbb2367de) - 💄[Load servarr mod stylesheets in the same order as when they were in the head](https://togithub.com/GilbN/theme.park/pull/507/commits/a6df7ca39d0ec32ee457ed5e2986c5040579745d) - 💄[Update gitea themes for 1.20](https://togithub.com/GilbN/theme.park/pull/507/commits/9850f655ed61cdee7b48ee6b3dbac76fe80ea362) ### Other - [Update mods workflow ](https://togithub.com/GilbN/theme.park/pull/507/commits/2f86f4a35ba6f28345e99b41ae7dba48ef084b5f) #### New Contributors - [@​zb140](https://togithub.com/zb140) made their first contribution in [https://github.com/GilbN/theme.park/pull/503](https://togithub.com/GilbN/theme.park/pull/503) - [@​aceArt-GmbH](https://togithub.com/aceArt-GmbH) made their first contribution in [https://github.com/GilbN/theme.park/pull/506](https://togithub.com/GilbN/theme.park/pull/506) - [@​ArchGryphon9362](https://togithub.com/ArchGryphon9362) made their first contribution in [https://github.com/GilbN/theme.park/pull/505](https://togithub.com/GilbN/theme.park/pull/505) **Full Changelog**: themepark-dev/theme.park@1.13.10...1.13.11 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41Ni4zIiwidXBkYXRlZEluVmVyIjoiMzYuNTYuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: repo-jeeves <106431701+repo-jeeves[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have read the contributing guideline and understand that I have made the correct modifications
PR's are done against the develop branch.
Bug fixes
Closes #502
Description:
When the fix was made for *arr apps to load the stylesheets into the HTML body instead of the header, they accidentally started getting loaded in backwards order compared to the order they'd been loaded in before. This meant that values in theme stylesheets were being overridden by values in base stylesheets, because the base sheets were loaded after the theme.
Benefits of this PR and context:
This PR ensures that the stylesheets are loaded in the same order they were loaded in before the move out of
<head>. That should help guarantee that anything that was working prior to the move will still work after.Thinking about it, I actually think it might make more sense to load the app's base CSS, then any addons, and then the theme CSS last, but since that's a potentially breaking change I stuck with making sure they get loaded in the same order they used to.
How Has This Been Tested?
I built the sonarr mod locally with the new changes and loaded it in my LSIO sonarr container and checked that the stylesheets are getting loaded in the expected order.
Source / References: