Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for KNX data secure #66

Merged
merged 80 commits into from
Jul 6, 2020
Merged

Add support for KNX data secure #66

merged 80 commits into from
Jul 6, 2020

Conversation

nanosonde
Copy link
Contributor

@nanosonde nanosonde commented Jun 18, 2020 •
edited
Loading

Add support for KNX data secure:

  • no access checking with roles is implemented (not planned). The device can just take part in secure communcation. Only the basic Group object security flags checking is implemented for secure group communication.

@nanosonde nanosonde changed the title Add support for KNX data secure WIP: Add support for KNX data secure Jun 18, 2020
@nanosonde
Copy link
Contributor Author

nanosonde commented Jun 18, 2020 •
edited
Loading

Not tested. Not finished. Just to give an impression of the current status.

@nanosonde nanosonde changed the title WIP: Add support for KNX data secure Add support for KNX data secure Jul 5, 2020
@nanosonde nanosonde marked this pull request as ready for review July 5, 2020 14:24
@nanosonde nanosonde changed the title Add support for KNX data secure WIP: Add support for KNX data secure Jul 5, 2020
@thelsing
Copy link
Owner

thelsing commented Jul 5, 2020

Can you resolve the conflicts with the main branch please?

@nanosonde nanosonde changed the title WIP: Add support for KNX data secure Add support for KNX data secure Jul 6, 2020
@nanosonde
Copy link
Contributor Author

nanosonde commented Jul 6, 2020 •
edited
Loading

So, now let's get it merged. 😁

@nanosonde nanosonde mentioned this pull request Jul 6, 2020
Closed
@thelsing thelsing merged commit 96884f7 into thelsing:master Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thelsing thelsing thelsing left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nanosonde @thelsing