Fix show-more being displayed over chat messages #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per erming/shout#568: With this PR I tried fixing #366 by changing it's position to relative. It wasn't a pretty sight to see "Show more" bar on existing chat messages. With this fix Show More button no more will overlap with the underneath text. As in:  Result will be like:  This fix also includes @xPaw 's contribution as well. PS: I mistakenly added another commit to this PR and removed it later. See #88 for the next one.
|
You've re-created the PR, but missed the discussion. Your fix should work as well if you remove Also you forgot to move over the changes that remove the no longer necessary padding and margins. |
|
Linking to #87 for discussion purposes. |
|
@xPaw, do you want to take ownership of this one? |
|
My bad, I totally forgot it after trying to rebase a few times. ^^ Removed padding related css entries as well. |
|
So you've created a new PR over the last one, but it includes exact same changes. Have you tested by removing |
|
Yes, Over chrome, the results were the same with Well, not exactly the same. The last PR had some extra commits I included by mistake so I had to cancel that one. That's the reason I opened a new one, due to my incompetency (: About |
|
Removing it should be fine. And you don't need to make a new PR to fix your mistakes, check this out http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html |
xPaw
added
the
Type: Bug
As per erming/shout#568: With this PR I tried fixing #366 by changing it's position to relative. It wasn't a pretty sight to see "Show more" bar on existing chat messages. With this fix Show More button no more will overlap with the underneath text. As in:  Result will be like:  This fix also includes @xPaw 's contribution as well. PS: I mistakenly added another commit to this PR and removed it later. See #88 for the next one. Removed padding related css entries for show-more
As per erming/shout#568: With this PR I tried fixing #366 by changing it's position to relative. It wasn't a pretty sight to see "Show more" bar on existing chat messages. With this fix Show More button no more will overlap with the underneath text. As in:  Result will be like:  This fix also includes @xPaw 's contribution as well. PS: I mistakenly added another commit to this PR and removed it later. See #88 for the next one. Removed padding related css entries for show-more Removed reference to position
# Conflicts: # client/css/style.css
# The first commit's message is: Fix show-more being displayed over chat messages As per erming/shout#568: With this PR I tried fixing #366 by changing it's position to relative. It wasn't a pretty sight to see "Show more" bar on existing chat messages. With this fix Show More button no more will overlap with the underneath text. As in:  Result will be like:  This fix also includes @xPaw 's contribution as well. PS: I mistakenly added another commit to this PR and removed it later. See #88 for the next one. Removed padding related css entries for show-more Removed reference to position # The 2nd commit message will be skipped: # Removed padding related css entries for show-more
As per erming/shout#568: With this PR I tried fixing #366 by changing it's position to relative. It wasn't a pretty sight to see "Show more" bar on existing chat messages. With this fix Show More button no more will overlap with the underneath text. As in:  Result will be like:  This fix also includes @xPaw 's contribution as well. PS: I mistakenly added another commit to this PR and removed it later. See #88 for the next one. Removed padding related css entries for show-more Removed reference to position
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per erming/shout#568:
With this PR I tried fixing #366 by changing it's position to relative.
It wasn't a pretty sight to see "Show more" bar on existing chat
messages.
With this fix Show More button no more will overlap with the underneath
text.
As in:
Result will be like:
This fix also includes @xPaw 's contribution as well.
PS: I mistakenly added another commit to this PR and removed it later.
See #88 for the next one.