Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standard-rails linting #4

Closed
wants to merge 26 commits into from
Closed

Add standard-rails linting #4

wants to merge 26 commits into from

Conversation

thejonroberts
Copy link
Owner

What github issue is this PR for, if any?

No issue. We use standardrb, why not use the standard-rails plugin?

What changed, and why?

  • Added standard-rails gem to facilitate code standards & consistency
  • Fixed safe fixes (one rule per commit, can review per commit if you wish)
  • Generated .standard_todo.yml to ignore current unsafe fixes
  • Unsafely fixed specs (again one rule per commit)
  • Removed specs from the todo

If we are apprehensive about so many changes to the codebase (merge conflicts anyone?), I can drop commits and make one big todo file.

I can squash the commits down before merge, I just wanted people to be able to see what rule did what.

How is this tested? (please write tests!) 💖💪

Current specs, no behavior changes.

Copy link

This PR has been open for a long time without any pushes or comments! What's up?

@thejonroberts thejonroberts deleted the standard-rails branch December 7, 2024 14:51
@thejonroberts thejonroberts restored the standard-rails branch December 7, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants