Make louvain an optional dependency #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #361 +/- ##
=======================================
Coverage 53.13% 53.13%
=======================================
Files 22 22
Lines 1848 1848
=======================================
Hits 982 982
Misses 866 866
Flags with carried forward coverage won't be shown. Click here to find out more.
|
LuckyMD
approved these changes
Jan 9, 2023
| plot=False, | ||
| inplace=True, | ||
| res_max, score_max, _ = scib.cl.cluster_optimal_resolution( | ||
| adata, label_key="celltype", cluster_key="cluster", return_all=True |
There was a problem hiding this comment.
order of parameters is different from order in conftest.py could you make this consistent?
There was a problem hiding this comment.
yes, leiden is the default for the cluster_optimal_resolution function.
LuckyMD
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses and closes #360