Bumped up the 'electron-builder' version #320

kittaakos · 2020-03-18T15:41:40Z

Closes #319

I have verified it locally, it builds and runs.

Upstream ref: electron-userland/electron-builder#3990 (comment)

Signed-off-by: Akos Kitta [email protected]

marcdumais-work · 2020-03-18T15:58:24Z

I built on Ubuntu 18.04 and got the following error when I tried to start the AppImage package:

theia-apps/theia-electron/dist$ ./Theia-0.1.0.AppImage 
Failed to start the backend application.
{ Error: Cannot find module 'fs-extra'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:584:15)
    at Function.Module._load (internal/modules/cjs/loader.js:510:25)
    at Module.require (internal/modules/cjs/loader.js:640:17)
    at require (internal/modules/cjs/helpers.js:20:18)
    at Object.<anonymous> (/tmp/.mount_Theia-iwXxfv/resources/app/node_modules/@theia/filesystem/lib/node/node-filesystem.js:94:10)
    at Object.<anonymous> (/tmp/.mount_Theia-iwXxfv/resources/app/node_modules/@theia/filesystem/lib/node/node-filesystem.js:980:3)
    at Module._compile (internal/modules/cjs/loader.js:693:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:704:10)
    at Module.load (internal/modules/cjs/loader.js:602:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:541:12) code: 'MODULE_NOT_FOUND' }
/tmp/.mount_Theia-iwXxfv/resources/app/node_modules/@theia/core/lib/node/main.js:56
    throw reason;
    ^

Error: Cannot find module 'fs-extra'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:584:15)
    at Function.Module._load (internal/modules/cjs/loader.js:510:25)
    at Module.require (internal/modules/cjs/loader.js:640:17)
    at require (internal/modules/cjs/helpers.js:20:18)
    at Object.<anonymous> (/tmp/.mount_Theia-iwXxfv/resources/app/node_modules/@theia/filesystem/lib/node/node-filesystem.js:94:10)
    at Object.<anonymous> (/tmp/.mount_Theia-iwXxfv/resources/app/node_modules/@theia/filesystem/lib/node/node-filesystem.js:980:3)
    at Module._compile (internal/modules/cjs/loader.js:693:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:704:10)
    at Module.load (internal/modules/cjs/loader.js:602:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:541:12)

kittaakos · 2020-03-18T16:03:24Z

Thanks for trying it out, I have cheated a bit and opened the app from ./dist/mac/Theia.app/Contents/MacOS/Theia. I did not install it to Applications. Just a guess, but I think a good one; we hit this issue. I will add a patch soon.

Also pinned 'fs-extra' version. Closes #319 Signed-off-by: Akos Kitta <[email protected]>

kittaakos · 2020-03-18T16:14:45Z

Please try again. Now I installed the app and it works here.

lmcbout · 2020-03-18T17:10:31Z

theia-electron/package.json

        "bufferutil": "4",
        "utf-8-validate": "5"
    },
+    "// Notes:": [
+        "The resolution for `fs-extra` was required due to this: https://spectrum.chat/theia/general/our-theia-electron-builder-app-no-longer-starts~f5cf09a0-6d88-448b-8818-24ad0ec2ee7c"
+    ],
    "resolutions": {
        "vscode-languageserver-protocol": "3.15.0-next.9",


I have an application for JAVA and the section "resolutions" is not needed anymore with the latest Theia. In here we still need the fs-extra only

I think we added the resolutions to all apps in this repo - maybe better to remove them all in one shot as well vs piecemeal?

marcdumais-work · 2020-03-18T18:27:13Z

Please try again. Now I installed the app and it works here.

Works now 👍

marcdumais-work · 2020-03-18T18:51:25Z

cc: @marechal-p : FYI, I think the problem with fs-extra, now gone in this iteration of the PR, may be related to your recent investigation about implicit npm dependencies. (original commit)

theia-apps/theia-electron$ yarn why fs-extra
yarn why v1.17.3
[1/4] Why do we have the module "fs-extra"...?
[2/4] Initialising dependency graph...
warning Resolution field "[email protected]" is incompatible with requested version "vscode-languageserver@^6.0.1"
warning Resolution field "[email protected]" is incompatible with requested version "vscode-languageserver-types@^3.15.1"
[3/4] Finding dependency...
[4/4] Calculating file sizes...
=> Found "[email protected]"
info Has been hoisted to "fs-extra"
info Reasons this module exists
   - Hoisted from "electron-builder#fs-extra"
   - Hoisted from "electron-builder#dmg-builder#fs-extra"
   - Hoisted from "electron-builder#app-builder-lib#fs-extra"
   - Hoisted from "electron-builder#read-config-file#fs-extra"
   - Hoisted from "electron-builder#builder-util#fs-extra"
   - Hoisted from "@theia#cli#@theia#application-manager#electron-rebuild#fs-extra"
   - Hoisted from "electron-builder#app-builder-lib#temp-file#fs-extra"
   - Hoisted from "electron-builder#app-builder-lib#electron-publish#fs-extra"
info Disk size without dependencies: "284KB"
info Disk size with unique dependencies: "376KB"
info Disk size with transitive dependencies: "376KB"
info Number of shared dependencies: 3
=> Found "@theia/core#[email protected]"
info This module exists because "@theia#core" depends on it.
info Disk size without dependencies: "388KB"
info Disk size with unique dependencies: "480KB"
info Disk size with transitive dependencies: "480KB"
info Number of shared dependencies: 3
=> Found "trash#[email protected]"
info This module exists because "@theia#filesystem#trash" depends on it.
info Disk size without dependencies: "248KB"
info Disk size with unique dependencies: "404KB"
info Disk size with transitive dependencies: "688KB"
info Number of shared dependencies: 12
=> Found "electron-download#[email protected]"
info This module exists because "@theia#electron#electron-download" depends on it.
info Disk size without dependencies: "388KB"
info Disk size with unique dependencies: "480KB"
info Disk size with transitive dependencies: "480KB"
info Number of shared dependencies: 3
=> Found "@theia/application-package#[email protected]"
info This module exists because "@theia#cli#@theia#application-package" depends on it.
info Disk size without dependencies: "388KB"
info Disk size with unique dependencies: "480KB"
info Disk size with transitive dependencies: "480KB"
info Number of shared dependencies: 3
=> Found "@theia/application-manager#[email protected]"
info This module exists because "@theia#cli#@theia#application-manager" depends on it.
info Disk size without dependencies: "388KB"
info Disk size with unique dependencies: "480KB"
info Disk size with transitive dependencies: "480KB"
info Number of shared dependencies: 3
=> Found "nsfw#[email protected]"
info This module exists because "@theia#core#nsfw" depends on it.
info Disk size without dependencies: "264KB"
info Disk size with unique dependencies: "356KB"
info Disk size with transitive dependencies: "356KB"
info Number of shared dependencies: 3
Done in 1.46s.

In the current iteration (with fs-extra pinned in resolutions block), we get:

theia-apps/theia-electron$ yarn why fs-extra
yarn why v1.17.3
[1/4] Why do we have the module "fs-extra"...?
[2/4] Initialising dependency graph...
warning Resolution field "[email protected]" is incompatible with requested version "vscode-languageserver@^6.0.1"
warning Resolution field "[email protected]" is incompatible with requested version "vscode-languageserver-types@^3.15.1"
[3/4] Finding dependency...
[4/4] Calculating file sizes...
=> Found "[email protected]"
info Reasons this module exists
   - "@theia#core" depends on it
   - Hoisted from "@theia#core#fs-extra"
   - Hoisted from "electron-builder#fs-extra"
   - Hoisted from "@theia#filesystem#trash#fs-extra"
   - Hoisted from "@theia#electron#electron-download#fs-extra"
   - Hoisted from "@theia#cli#@theia#application-package#fs-extra"
   - Hoisted from "@theia#cli#@theia#application-manager#fs-extra"
   - Hoisted from "@theia#core#nsfw#fs-extra"
   - Hoisted from "electron-builder#builder-util#fs-extra"
   - Hoisted from "electron-builder#dmg-builder#fs-extra"
   - Hoisted from "electron-builder#read-config-file#fs-extra"
   - Hoisted from "electron-builder#app-builder-lib#fs-extra"
   - Hoisted from "@theia#cli#@theia#application-manager#electron-rebuild#fs-extra"
   - Hoisted from "electron-builder#app-builder-lib#electron-publish#fs-extra"
   - Hoisted from "electron-builder#app-builder-lib#temp-file#fs-extra"
info Disk size without dependencies: "388KB"
info Disk size with unique dependencies: "480KB"
info Disk size with transitive dependencies: "480KB"
info Number of shared dependencies: 3
Done in 1.73s.

marcdumais-work

LGTM, thanks @kittaakos

marcdumais-work · 2020-03-18T18:59:31Z

Just a guess, but I think a good one; we hit this issue. I will add a patch soon.

Indeed, the output from yarn list looks almost identical to what I got

kittaakos requested review from marcdumais-work and vince-fugnitto March 18, 2020 15:41

Bumped up the 'electron-builder' version

cde78ba

Also pinned 'fs-extra' version. Closes #319 Signed-off-by: Akos Kitta <[email protected]>

kittaakos force-pushed the GH-319 branch from 5a93173 to cde78ba Compare March 18, 2020 16:14

lmcbout reviewed Mar 18, 2020

View reviewed changes

marcdumais-work approved these changes Mar 18, 2020

View reviewed changes

kittaakos merged commit 0cc6a3d into master Mar 19, 2020

kittaakos deleted the GH-319 branch March 19, 2020 08:54

kittaakos mentioned this pull request May 6, 2020

Update uuid to v8 eclipse-theia/theia#7749

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bumped up the 'electron-builder' version #320

Bumped up the 'electron-builder' version #320

kittaakos commented Mar 18, 2020

marcdumais-work commented Mar 18, 2020

kittaakos commented Mar 18, 2020

kittaakos commented Mar 18, 2020

lmcbout Mar 18, 2020

marcdumais-work Mar 18, 2020

marcdumais-work commented Mar 18, 2020

marcdumais-work commented Mar 18, 2020

marcdumais-work left a comment

marcdumais-work commented Mar 18, 2020 •

edited

Loading

Bumped up the 'electron-builder' version #320

Bumped up the 'electron-builder' version #320

Conversation

kittaakos commented Mar 18, 2020

marcdumais-work commented Mar 18, 2020

kittaakos commented Mar 18, 2020

kittaakos commented Mar 18, 2020

lmcbout Mar 18, 2020

Choose a reason for hiding this comment

marcdumais-work Mar 18, 2020

Choose a reason for hiding this comment

marcdumais-work commented Mar 18, 2020

marcdumais-work commented Mar 18, 2020

marcdumais-work left a comment

Choose a reason for hiding this comment

marcdumais-work commented Mar 18, 2020 • edited Loading

marcdumais-work commented Mar 18, 2020 •

edited

Loading