Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resolvable URL query params filters, fix issues. #1580

Merged
merged 6 commits into from
Jan 13, 2025
Merged

Conversation

ewelinagr
Copy link
Member

Adds feature to enable redirection links to Fairspace with metadata prefiltering as a first step for enhancing external tools integration with Fairspace.

Fixes smaller issues, including right panel property ordering using sh:order, metadata validation error message improvements and changes to metadata query filters to be case insensitive.

@ewelinagr ewelinagr requested a review from pvannierop January 2, 2025 08:40
@@ -1,4 +1,5 @@
import React from 'react';
// import {useHistory} from 'react-router-dom';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to deliberately keep these comments in the code?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, thanks for spotting that, those are removed now

Copy link

@peyman-mohtashami peyman-mohtashami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I reviewed just Reactjs-related files and not Java files.

@ewelinagr ewelinagr merged commit 08f6e4b into dev Jan 13, 2025
6 checks passed
@ewelinagr ewelinagr deleted the url-filter-parsing branch January 13, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants