Potential workaround for Exynos gatt server implementation #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to theheraldproject#111. Advertiser API divergence. - May fix issues on S20 (Exynos based ones, SnapDragon already work) - For External testing Signed-off-by: Adam Fowler <[email protected]>
Extra debug logging to try and replicate theheraldproject#107 - Now issue potentially traced to Exynos based Samsung devices we can try and replicate - This change only applies extra logging to confirm the issue cause locally - ISV partner has an Exynos S20 for testing Signed-off-by: Adam Fowler <[email protected]>
Related to theheraldproject#107. Potential workaround for Exynos gatt server implementation - Existing gattServer instances on devices with the Exynos base chipset do not remove adverts from the same source app - Affects Exynos version of some Samsung handsets, but not the more prevalent SnapDragon versions - Only causes an issue in testing if Bluetooth is turned on/off 23 times - a rare occurrence in normal usage - Without the fix Herald would still allow an affected device to interact with other devices (iOS and Android) thanks to the 'calling card' / write characteristic - Does not cause an issue for detection unless write characteristic/calling card is disabled (Not done in the Herald code base or library) - Issue theheraldproject#110 also occurs on Exynos based handsets only - Committing to develop to allow third party ISV testing today Signed-off-by: Adam Fowler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #107. Potential workaround for Exynos gatt server implementation
Signed-off-by: Adam Fowler [email protected]