WIP: Start implementing UNFCCC carbon intensity provider #8 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sharing now so I can hide my incompetence later in a tidier branch
Go is not python, obvs
To avoid being doing everything on an easy to lose laptop
|
I've emailed again. There was a meeting on July 1st to make a decision about opening this data up, so when I hear back we'll know about proceeding. @rossf7 this has been open for a couple of releases now. Should I close this? We already have issue #8 which explains the UNFCCC data, and it might be simpler to make a new PR from the updated code. |
|
@mrchrisadams Thanks for checking with them. I think it makes sense to close this as it would need updating to use the new structure. Once the new structure is in place I think we should document whichever provider we add next. This will make adding further providers easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for #8 where I'm blundering through picking up bits of Golang to implement a new provider that would provide a set of default annual carbon intensity values for the last year for common regions and countries.
This would mean you can use the grid intensity library as a CLI or in the grid-intensity-exporter, without immediately needing to speak to a third party API.