Fix test and add changelog for 0.7.0 #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ross Fairbanks <[email protected]>
Signed-off-by: Ross Fairbanks <[email protected]>
Signed-off-by: Ross Fairbanks <[email protected]>
rossf7
commented
Jun 11, 2024
| @@ -1,24 +1,27 @@ | |||
| name: docker-integration-test | |||
| on: [push] | |||
| on: [pull_request, push] | |||
There was a problem hiding this comment.
@mrchrisadams Push doesn't work for forks 🤦♂️ now we will run the integration tests once a PR is created.
I also did some code gardening and updated the actions versions.
| - Update Electricity Maps provider to return both estimated and actual values. | ||
| Note: There is a delay before actual values are available. | ||
| - Update location parameter to support multiple locations separated with a | ||
| comma. |
There was a problem hiding this comment.
@mrchrisadams PTAL 🙏 Do these release notes look OK?
rossf7
commented
Jun 11, 2024
| uses: actions/checkout@v4 | ||
| - | ||
| name: Set up Go | ||
| uses: actions/setup-go@v5 |
There was a problem hiding this comment.
The go version in the Actions VM is usually pretty old. We used setup-go in the release action. Now we use it in all of them
mrchrisadams
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.