Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to pass location codes in CSV format #82

Merged
merged 4 commits into from
Jun 9, 2024

Conversation

ZeidH
Copy link
Contributor

@ZeidH ZeidH commented May 22, 2024

For both the CLI and Exporter you can now pass a comma-separated list with the --location param or the GRID_INTENSITY_LOCATION environment variable.

The response format remains unchanged as it already returned a JSON array.

@rossf7
Copy link
Contributor

rossf7 commented Jun 3, 2024

@ZeidH Thank you!

From a Go POV this LGTM however it would be good to update the help text now that multiple locations are supported.

We use the cobra library for this and the flag is on both the root and exporter commands so ideally it should be a constant.

rootCmd.Flags().StringP(locationKey, "l", "", "Location code for provider")

exporterCmd.Flags().StringP(locationKey, "l", "", "Location code for provider")

Are you OK to add that?

Copy link
Contributor

@rossf7 rossf7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants