Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add github action to run go unit tests #7

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Add github action to run go unit tests #7

merged 1 commit into from
Dec 7, 2020

Conversation

rossf7
Copy link
Contributor

@rossf7 rossf7 commented Dec 7, 2020 •
edited
Loading

I've been using github actions in the exporter. I think we can use them here too for running the unit tests.

I also added a status badge for the godoc. As I think that's useful since this is a library.

@rossf7 rossf7 self-assigned this Dec 7, 2020
@rossf7 rossf7 marked this pull request as ready for review December 7, 2020 15:17
ofpiyush
ofpiyush approved these changes Dec 7, 2020
View reviewed changes
Copy link
Collaborator

@ofpiyush ofpiyush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton for setting this up!

@ofpiyush ofpiyush merged commit bbae1f9 into main Dec 7, 2020
@ofpiyush ofpiyush deleted the go-unit-test branch December 7, 2020 15:38
@rossf7
Copy link
Contributor Author

rossf7 commented Dec 7, 2020

Thanks for the quick review @ofpiyush!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofpiyush ofpiyush ofpiyush approved these changes

@mrchrisadams mrchrisadams Awaiting requested review from mrchrisadams

Assignees

@rossf7 rossf7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rossf7 @ofpiyush