Migrate Ember provider to new structure #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossf7
changed the title
rossf7
commented
Aug 2, 2022
|
|
||
| func getGridIntensityData() (map[string]GridIntensity, error) { | ||
| data := map[string]GridIntensity{} | ||
| func GetEmberGridIntensity() (map[string]EmberGridIntensity, error) { |
There was a problem hiding this comment.
This new pkg/internal/data package means the data and logic for getting the data file is separate from the provider.
We could extend this for other data files or to add more Ember data. The internal name is so its clear this isn't part of the public API.
There was a problem hiding this comment.
I hadn't thought of this as an idea, but I really like it. It's also something we could use on any other libraries that use local data. 👍
rossf7
commented
Aug 2, 2022
| } | ||
|
|
||
| validFrom := time.Date(emberDataYear, 1, 1, 0, 0, 0, 0, time.UTC) | ||
| validTo := time.Date(emberDataYear, 12, 31, 23, 59, 0, 0, time.UTC) |
There was a problem hiding this comment.
Here we set the time period for the data.
|
hey @rossf7 - this is good to merge in. Thanks! |
mrchrisadams
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #44