Add carbonintensity.org.uk provider to CLI #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossf7
commented
Jul 13, 2022
| @@ -41,14 +39,25 @@ type ApiClient struct { | |||
| } | |||
|
|
|||
| func (a *ApiClient) GetCarbonIntensity(ctx context.Context, region string) (float64, error) { | |||
| latestData, err := a.getLatestCarbonIntensityData(ctx, region) | |||
| data, err := a.getCarbonIntensityData(ctx, region) | |||
There was a problem hiding this comment.
The latest in the name was bugging me as I think its redundant.
rossf7
commented
Jul 13, 2022
| } | ||
| if regionCode != "UK" { | ||
| return fmt.Errorf("only region UK is supported") | ||
| } |
There was a problem hiding this comment.
We default the region but also check it is set to UK.
mrchrisadams
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment the CLI only supports Ember and WattTime. For consistency I think we should enable all providers.
This adds carbonintensity.org.uk I'd like to add ElectricityMap as well but I'll do that as a separate PR and I could do with a license key for testing.