Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An error is thrown when trying to run quire epub #671

Closed
1 task done
geealbers opened this issue Feb 21, 2023 · 1 comment
Closed
1 task done

An error is thrown when trying to run quire epub #671

geealbers opened this issue Feb 21, 2023 · 1 comment

Comments

@geealbers
Copy link
Member

Before proceeding, check to make sure there isn’t an existing issue for this bug.

  • I have searched the existing issues and determined this is a new bug.

Steps to reproduce

Start a new project using cli v1.0.0-rc.3 and run quire epub. (Not sure if you need to run quire build beforehand, but whether you do or don't the resulting behavior is the same.)

Actual behavior

An error is thrown:

galbers@GT29043 test-rc3-lts % quire epub
file:///Users/galbers/.nvm/versions/node/v18.12.1/lib/node_modules/@thegetty/quire-cli/src/lib/epub/index.js:14
  switch (lib.toLowerCase()) {
              ^

TypeError: lib.toLowerCase is not a function
    at default (file:///Users/galbers/.nvm/versions/node/v18.12.1/lib/node_modules/@thegetty/quire-cli/src/lib/epub/index.js:14:15)
    at Command.action (file:///Users/galbers/.nvm/versions/node/v18.12.1/lib/node_modules/@thegetty/quire-cli/src/commands/epub.js:51:27)
    at Command.listener [as _actionHandler] (/Users/galbers/.nvm/versions/node/v18.12.1/lib/node_modules/@thegetty/quire-cli/node_modules/commander/lib/command.js:482:17)
    at /Users/galbers/.nvm/versions/node/v18.12.1/lib/node_modules/@thegetty/quire-cli/node_modules/commander/lib/command.js:1283:65
    at Command._chainOrCall (/Users/galbers/.nvm/versions/node/v18.12.1/lib/node_modules/@thegetty/quire-cli/node_modules/commander/lib/command.js:1177:12)
    at Command._parseCommand (/Users/galbers/.nvm/versions/node/v18.12.1/lib/node_modules/@thegetty/quire-cli/node_modules/commander/lib/command.js:1283:27)
    at /Users/galbers/.nvm/versions/node/v18.12.1/lib/node_modules/@thegetty/quire-cli/node_modules/commander/lib/command.js:1081:27
    at Command._chainOrCall (/Users/galbers/.nvm/versions/node/v18.12.1/lib/node_modules/@thegetty/quire-cli/node_modules/commander/lib/command.js:1177:12)
    at Command._dispatchSubcommand (/Users/galbers/.nvm/versions/node/v18.12.1/lib/node_modules/@thegetty/quire-cli/node_modules/commander/lib/command.js:1077:23)
    at Command._parseCommand (/Users/galbers/.nvm/versions/node/v18.12.1/lib/node_modules/@thegetty/quire-cli/node_modules/commander/lib/command.js:1248:19)

Expected behavior

Instead, an EPUB of the project should have been generated.

Version numbers

macoS Monterey (12.6)
Quire CLI 1.0.0-rc.3
Quire 11ty 1.0.0-rc.3
Node 18.12.1

What browsers are you seeing the problem on?

No response

Relevant Terminal/Shell output

No response

Supporting Information

No response

@geealbers geealbers added the status:triage needed Issue needs to be triaged by the Quire team. This label is automatically applied to new issues. label Feb 21, 2023
mphstudios added a commit that referenced this issue Mar 7, 2023
### Fixed

- Correct switch statement condition for configuring the Epub lib #671
- Normalize the lib name before conditionally loading an `epub` or `pdf` library
@geealbers
Copy link
Member Author

Fixed as of 1.0.0-rc.6 release of the CLI

@Erin-Cecele Erin-Cecele removed the status:triage needed Issue needs to be triaged by the Quire team. This label is automatically applied to new issues. label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants