Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(npm): generate separate types for esm #702

Merged
merged 3 commits into from
May 30, 2023
Merged

chore(npm): generate separate types for esm #702

merged 3 commits into from
May 30, 2023

Conversation

neurosnap
Copy link
Collaborator

Reference: denoland/dnt#307

Motivation

Approach

All we need to do is upgrade dnt and it will automatically generate separate types for cjs and esm.

cowboyd
cowboyd approved these changes May 29, 2023
View reviewed changes
Copy link
Member

@cowboyd cowboyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 Thanks for tracking this down!

@cowboyd
Copy link
Member

cowboyd commented May 29, 2023

@neurosnap Looks like there is an issue with the deno.lock Do we need to update it?

@neurosnap neurosnap requested a review from cowboyd May 29, 2023 18:39
@neurosnap
Copy link
Collaborator Author

neurosnap commented May 29, 2023 •
edited by unfurl-links bot
Loading

The issue is that esm.sh dependencies need to be pinned: https://esm.sh/#faq

A fast, smart & global CDN for modern(es2015+) web development.

@neurosnap neurosnap merged commit 6bb7b77 into v3 May 30, 2023
@neurosnap neurosnap deleted the esm-types branch May 30, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cowboyd cowboyd Awaiting requested review from cowboyd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neurosnap @cowboyd