Added a way to stop the operation #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
tm/separate-retry-from-initial-attempt
to
main
January 16, 2024 14:50
cowboyd
reviewed
Jan 16, 2024
| for (const value of yield* each(channel)) { | ||
| setState(value); | ||
| if (value.type === "stopped") { | ||
| throw new Error("Forced interrupt") |
There was a problem hiding this comment.
You can just stop your iteration and the updates task will win your race. I'd do that since it is an expected condition.
Suggested change
| throw new Error("Forced interrupt") | |
| break; |
There was a problem hiding this comment.
I'm throwing the error to short-circuit the other child operations. Will break do the same here?
There was a problem hiding this comment.
If I read it correctly, then yes. breaking here exits the loop, which then causes the updates task to win the race, which then causes the main task invoked with run() to return, which then shuts down everything created in that scope.
There was a problem hiding this comment.
oh nice, I didn't catch that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I want to be able to stop the loader when encountering an error. This is useful when encountering a "VPN not connected" situation. In this case, I want to stop the operation and not have it do anything else.
Approach
suspendTODOs and Open Questions