Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a jsTSConfig to the rollup typescript plugin if no tsconfig is found #961

Merged
merged 2 commits into from
Aug 3, 2021

Conversation

dagda1
Copy link
Contributor

@dagda1 dagda1 commented Aug 2, 2021

Motivation

Fix for #959 where an annoying warning is displayed if no tsconfig.json exists

Approach

Add a js tsconfig.json if no tsconfig.json is found to the rollup typescript plugin.

This js tsconfig has the "allowJs": true compiler option set.

@dagda1 dagda1 requested a review from jbolda August 2, 2021 13:10
@changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2021

🦋 Changeset detected

Latest commit: a8d513a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@bigtest/bundler Minor
@bigtest/server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dagda1 dagda1 added the preview to publish preview packages label Aug 2, 2021
@dagda1 dagda1 requested a review from cowboyd August 2, 2021 13:33
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2021

The preview packages of this pull request have been published.
Click on the following packages for instructions on how to install them:

@bigtest/bundler

Install using the following command:

$ npm install @bigtest/bundler@allow-js

Or update your package.json file:

{
  "@bigtest/bundler": "allow-js"
}

@bigtest/project

Install using the following command:

$ npm install @bigtest/project@allow-js

Or update your package.json file:

{
  "@bigtest/project": "allow-js"
}

Generated by 🚫 dangerJS against a8d513a

@dagda1 dagda1 merged commit 7d5e7d5 into v0 Aug 3, 2021
@dagda1 dagda1 deleted the allow-js branch August 3, 2021 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview to publish preview packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants