Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump docusaurus to v2.0.0-beta.3 #951

Merged
merged 3 commits into from
Jul 29, 2021
Merged

Bump docusaurus to v2.0.0-beta.3 #951

merged 3 commits into from
Jul 29, 2021

Conversation

cherewaty
Copy link
Collaborator

Motivation

Ran into some problems attempting to customize the webpack config on the alpha version of docusaurus 2.

Approach

Upgrade.

This change introduced stricter use of url-loader, where use of url() in CSS files was breaking. I just slapped a webpack ignore on those for now, since we're exploring changing the CSS build tooling in the coming days.

Learning

https://github.com/facebook/docusaurus/releases/tag/v2.0.0-beta.3

@changeset-bot
Copy link

changeset-bot bot commented Jul 20, 2021

⚠️ No Changeset found

Latest commit: daf0e1b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cherewaty cherewaty marked this pull request as draft July 20, 2021 20:43
@cherewaty cherewaty force-pushed the docusaurus-v2.0.0-beta.3 branch from 1855083 to 831fab4 Compare July 20, 2021 20:56
@cherewaty cherewaty marked this pull request as ready for review July 21, 2021 17:28
@minkimcello
Copy link
Contributor

Screen Shot 2021-07-22 at 7 22 14 AM
I think we need to add some new config to remove the banner?

@cherewaty
Copy link
Collaborator Author

Thanks @minkimcello 🙌 fixed in new commit.

Copy link
Contributor

@jorgelainfiesta jorgelainfiesta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks Jeffrey!

@cherewaty cherewaty merged commit df0d750 into v0 Jul 29, 2021
@cherewaty cherewaty deleted the docusaurus-v2.0.0-beta.3 branch July 29, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants