-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 3.1.4_browser_compatibility.md #1933
Conversation
Since the foreman started using the patternfly-v4 library, it is not compatible with IE anymore. Also, it requires the latest versions of the supported browsers: https://www.patternfly.org/v4/get-started/about#supported-browsers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How far back do we need to cherry pick this?
* Google Chrome latest | ||
* Microsoft Edge latest | ||
* Mozilla Firefox latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is acceptable. Browsers also have LTS versions and we should always require the latest version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree it shouldn't be acceptable but this is what pf4 gives us to work with.
The most we can do is to manually set up the current latest LTS release every time we release foreman. It also means that we will need to be careful with cherry-picks that upgrade the pf package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should take this as feedback to the PF4 team. Just as a context: Firefox on RHEL is an LTS release. That means a team of Red Hat people don't support their own platform.
I'm not sure, we added the pf4 to the vendor at v4.2.0: foreman v2.0 asks for foreman v2.1 uses vendor v4.3.0 so it's must contain pf4: |
What is the status please? |
Superseded by #1959 |
Since the foreman started using the patternfly-v4 library, it is not compatible with IE anymore.
Also, it requires the latest versions of the supported browsers:
https://www.patternfly.org/v4/get-started/about#supported-browsers