Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 3.1.4_browser_compatibility.md #1933

Closed
wants to merge 1 commit into from

Conversation

sharvit
Copy link

@sharvit sharvit commented Dec 9, 2021

Since the foreman started using the patternfly-v4 library, it is not compatible with IE anymore.
Also, it requires the latest versions of the supported browsers:
https://www.patternfly.org/v4/get-started/about#supported-browsers

Since the foreman started using the patternfly-v4 library, it is not compatible with IE anymore.
Also, it requires the latest versions of the supported browsers:
https://www.patternfly.org/v4/get-started/about#supported-browsers
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How far back do we need to cherry pick this?

Comment on lines +6 to +8
* Google Chrome latest
* Microsoft Edge latest
* Mozilla Firefox latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is acceptable. Browsers also have LTS versions and we should always require the latest version.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it shouldn't be acceptable but this is what pf4 gives us to work with.
The most we can do is to manually set up the current latest LTS release every time we release foreman. It also means that we will need to be careful with cherry-picks that upgrade the pf package.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should take this as feedback to the PF4 team. Just as a context: Firefox on RHEL is an LTS release. That means a team of Red Hat people don't support their own platform.

@sharvit
Copy link
Author

sharvit commented Dec 9, 2021

How far back do we need to cherry pick this?

I'm not sure, we added the pf4 to the vendor at v4.2.0:
https://github.com/theforeman/foreman-js/blob/master/CHANGELOG.md#420-2020-03-15

foreman v2.0 asks for ^4.0.7 so it depends on packaging:
https://github.com/theforeman/foreman/blob/2.0-stable/package.json#L23

foreman v2.1 uses vendor v4.3.0 so it's must contain pf4:
https://github.com/theforeman/foreman/blob/2.1-stable/package.json#L23

@lzap
Copy link
Member

lzap commented Mar 17, 2022

What is the status please?

@ekohl
Copy link
Member

ekohl commented Mar 18, 2022

Superseded by #1959

@ekohl ekohl closed this Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants